Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 876421 - media-sound/abcmidi-2024.03.05 fails to compile (lto): queues.c:65:12: error: type of [-Werror=lto-type-mismatch]
Summary: media-sound/abcmidi-2024.03.05 fails to compile (lto): queues.c:65:12: error:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-10-10 07:15 UTC by Agostino Sarubbo
Modified: 2024-03-27 06:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,52.06 KB, text/plain)
2022-10-10 07:15 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-10-10 07:15:39 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/abcmidi-2022.09.01 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-10-10 07:15:41 UTC
Created attachment 823360 [details]
build.log

build log and emerge --info
Comment 2 Miroslav Šulc gentoo-dev 2023-02-23 08:40:04 UTC
media-sound/abcmidi-2023.02.08 still affected
Comment 3 Miroslav Šulc gentoo-dev 2023-04-24 07:08:33 UTC
media-sound/abcmidi-2023.03.24 still affected
Comment 4 Miroslav Šulc gentoo-dev 2023-07-01 07:24:31 UTC
2023.06.25 still affected
Comment 5 Miroslav Šulc gentoo-dev 2023-10-14 08:07:30 UTC
2023.09.13 still affected
Comment 6 Miroslav Šulc gentoo-dev 2023-11-02 06:56:58 UTC
2023.11.01 still affected
Comment 7 Miroslav Šulc gentoo-dev 2023-12-29 09:03:03 UTC
2023.12.28 still affected
Comment 8 Agostino Sarubbo gentoo-dev 2024-03-14 09:14:46 UTC
lto_tinderbox has reproduced this issue with version 2024.03.05 - Updating summary.
Comment 9 Larry the Git Cow gentoo-dev 2024-03-27 06:02:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07bbabda51433519de7add55ccdbfb9f35571487

commit 07bbabda51433519de7add55ccdbfb9f35571487
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-27 05:59:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-27 06:01:22 +0000

    media-sound/abcmidi: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/876421
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/abcmidi/abcmidi-2024.01.04.ebuild | 11 ++++++++++-
 media-sound/abcmidi/abcmidi-2024.03.13.ebuild | 11 ++++++++++-
 media-sound/abcmidi/abcmidi-2024.03.21.ebuild | 11 ++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)