Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 87622 - sys-kernel/linux-headers installs backup files generated by patch
Summary: sys-kernel/linux-headers installs backup files generated by patch
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: SpanKY
Depends on:
Reported: 2005-04-01 19:53 UTC by James Rowe
Modified: 2005-04-02 20:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

linux-headers-no-backup-files.patch (linux-headers-no-backup-files.patch,403 bytes, patch)
2005-04-01 19:54 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2005-04-01 19:53:16 UTC
sys-kernel/linux-headers as of sys-kernel/linux-headers-
installs 228k of .orig "--backup-if-mismatch" patch files.  Judging by the
reason I would imagine every single user of kernel.eclass' src_install is
installing some amount of useless .orig files(at least if they apply
patches with *any* fuzz).

  Being enormously lazy I would personally just add a find and rm to 
src_install() in the eclass, but I imagine others would rather attack the
cause of the problem if they consider 228k to be a problem at all.

  Other methods would be setting $EPATCH_OPTS to include
--no-backup-if-mismatch, or setting this globally in eutils.eclass because
there are no doubt other instances[1] of this or ignoring it as a non-problem
of course ;)

1. I say there may be other instances of this, but I haven't found a single
one in the other 296 packages installed on this box.  You can do a
no guarantees quick search for other possible packages with the command:

        grep -Rl \\.orig `find /var/db/pkg/ -name CONTENTS`

Reproducible: Always
Steps to Reproduce:
Comment 1 James Rowe 2005-04-01 19:54:06 UTC
Created attachment 55074 [details, diff]
Comment 2 Tim Yamin (RETIRED) gentoo-dev 2005-04-02 15:31:07 UTC
Mike, patch look good?
Comment 3 SpanKY gentoo-dev 2005-04-02 20:23:52 UTC
i pointed this out to a long time ago ... and it was fixed in kernel-2.eclass

i dont see the point since we shouldnt be using kernel.eclass anymore