87539 – mpg123 doesn't use CFLAGS from make.conf on amd64, patch included.

Bug 87539 - mpg123 doesn't use CFLAGS from make.conf on amd64, patch included.

Summary: mpg123 doesn't use CFLAGS from make.conf on amd64, patch included.

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	AMD64 Linux

Importance:	High enhancement (vote)
Assignee:	Gentoo Sound Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-04-01 03:49 UTC by Simon Strandman
Modified:	2005-10-17 04:54 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch. (x86_64_CFLAGS.patch,854 bytes, patch) 2005-04-01 03:50 UTC, Simon Strandman	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Strandman 2005-04-01 03:49:49 UTC

Mpg123 doesn't use CFLAGS from make.conf on amd64. I have made a patch to fix that. I have also tries to compile it with a lot of different CFLAGS combinations and it seems stable even with insane optimizations.

Reproducible: Always
Steps to Reproduce:

Comment 1 Simon Strandman 2005-04-01 03:50:12 UTC

Created attachment 55023 [details, diff]
Patch.

Comment 2 Danny van Dyk (RETIRED) gentoo-dev

2005-07-15 23:44:15 UTC

Has nothing to do with amd64.

Comment 3 Simon Strandman 2005-10-15 12:18:11 UTC

Anything happening here?

Here are some results:

Before applying my patch (compiling unoptimized):

[12:18] Decoding of foo.mp3 finished.

real    0m14.533s
user    0m14.133s
sys     0m0.358s

After applying my patch:

[12:18] Decoding of foo.mp3 finished.

real    0m3.942s
user    0m3.628s
sys     0m0.271s

As you can see the patched mpg123 is more than three times faster. So please
apply it. :)

Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-10-17 04:54:25 UTC

Thanks, fixed in -r10 in CVS.