https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-strategy/s25rttr-0.9.5 fails tests (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 816148 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Created attachment 816151 [details] 1-LastTest.log 1-LastTest.log
14/20 Testing: Test_lua 14/20 Test: Test_lua Command: "/var/tmp/portage/games-strategy/s25rttr-0.9.5/work/s25client_v0.9.5_build/bin/Test_lua" Directory: /var/tmp/portage/games-strategy/s25rttr-0.9.5/work/s25client_v0.9.5_build "Test_lua" start time: Sep 30 19:02 CEST Output: ---------------------------------------------------------- Running 26 test cases... /var/tmp/portage/games-strategy/s25rttr-0.9.5/work/s25client_v0.9.5/tests/s25Main/lua/testLua.cpp(127): [4;31;49mfatal error: in "LuaTestSuite/Translations": critical check getLog() == "Eng\n" has failed [Did not found translation for language 'C.UTF8' in LUA file. Available translations: en_GB Eng != Eng ][0;39;49m [1;31;49m*** 1 failure is detected in the test module "RTTR_Lua" [0;39;49m <end of output> Test time = 0.84 sec ---------------------------------------------------------- Test Failed. "Test_lua" end time: Sep 30 19:02 CEST "Test_lua" time elapsed: 00:00:00 ---------------------------------------------------------- Surely not LTO.
