Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 871951 - media-video/xine-ui-0.99.13 - In function 'strlcpy': utils.h:77:58: error: expected declaration specifiers before 'ATTR_INLINE_ALL_STRINGOPS'
Summary: media-video/xine-ui-0.99.13 - In function 'strlcpy': utils.h:77:58: error: ex...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC64 Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL: https://sourceforge.net/p/xine/ticket...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 868030
  Show dependency tree
 
Reported: 2022-09-19 22:27 UTC by ernsteiswuerfel
Modified: 2022-09-30 02:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (ppc64) (xine-ui-0.99.13:20220919-222103.log,20.01 KB, text/plain)
2022-09-19 22:27 UTC, ernsteiswuerfel
Details
emerge --info (file_871951.txt,6.39 KB, text/plain)
2022-09-19 22:29 UTC, ernsteiswuerfel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2022-09-19 22:27:41 UTC
Created attachment 812986 [details]
build.log (ppc64)

[...]
make[3]: Entering directory '/var/tmp/portage/media-video/xine-ui-0.99.13/work/xine-ui-0.99.13/src/common'
powerpc64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../.. -I../../src -I../../src -I../../src/common -I../../src/common -I../../src/xitk/xine-toolkit -I../../src/xitk/xine-toolkit -I/usr/include    -Wall -fstrict-aliasing -D_FILE_OFFSET_BITS=64 -Wpointer-arith -Wnested-externs -Wcast-align -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -O2 -mcpu=970 -mtune=970 -pipe  -DNDEBUG -O3 -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute  -Wmissing-noreturn -Wdisabled-optimization -Werror-implicit-function-declaration -Wstrict-aliasing=2 -c -o config_wrapper.o config_wrapper.c
In file included from config_wrapper.c:33:
utils.h:77:8: warning: no previous prototype for 'strlcpy' [-Wmissing-prototypes]
   77 | size_t strlcpy (char *dst, const char *src, size_t size) ATTR_INLINE_ALL_STRINGOPS;
      |        ^~~~~~~
utils.h: In function 'strlcpy':
utils.h:77:58: error: expected declaration specifiers before 'ATTR_INLINE_ALL_STRINGOPS'
   77 | size_t strlcpy (char *dst, const char *src, size_t size) ATTR_INLINE_ALL_STRINGOPS;
      |                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~
config_wrapper.c:54:78: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
   54 | int config_update_string (xine_t *xine, const char *key, const char *string) {
      |                                                                              ^
config_wrapper.c:69:66: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
   69 | int config_update_num (xine_t *xine, const char *key, int value) {
      |                                                                  ^
config_wrapper.c:84:48: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
   84 | int config_mrl (xine_t *xine, const char *mrl) {
      |                                                ^
In file included from config_wrapper.c:33:
utils.h:77:8: error: old-style parameter declarations in prototyped function definition
   77 | size_t strlcpy (char *dst, const char *src, size_t size) ATTR_INLINE_ALL_STRINGOPS;
      |        ^~~~~~~
config_wrapper.c:151: error: expected '{' at end of input
config_wrapper.c:151: warning: control reaches end of non-void function [-Wreturn-type]
make[3]: *** [Makefile:499: config_wrapper.o] Error 1
Comment 1 ernsteiswuerfel archtester 2022-09-19 22:29:00 UTC
Created attachment 812989 [details]
emerge --info
Comment 2 Matt Turner gentoo-dev 2022-09-20 13:55:36 UTC
Does the stable version of xine-ui build for you?
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-20 17:31:21 UTC
Upstream were quite responsive when I filed a bug last. Could you try filing one at https://sourceforge.net/p/xine/tickets/ and pop the link here if/when you do? Thank you!
Comment 4 ernsteiswuerfel archtester 2022-09-21 12:50:32 UTC
(In reply to Matt Turner from comment #2)
> Does the stable version of xine-ui build for you?
Yes, 0.99.13 builds fine.
Comment 5 ernsteiswuerfel archtester 2022-09-21 12:53:18 UTC
Erm, I meant 0.99.12 builds fine...

There was already an upstream issue posted about this (https://sourceforge.net/p/xine/tickets/10/). Also the mentioned patch at https://sourceforge.net/p/xine/xine-ui/ci/f9a98e02460348ca23ca2f5c2b39e62c8758b22d/ works and 0.99.13.

Though it seems you only need the 1st part of the patch to make 0.99.13 build on ppc64:

--- a/configure.ac	2021-12-12 20:49:29.000000000 +0100
+++ b/configure.ac	2022-09-21 14:41:38.245392764 +0200
@@ -600,8 +600,10 @@
 ])], [have_attr_iaso=yes], [have_attr_iaso=no])
 AC_MSG_RESULT([$have_attr_iaso])
 if test x"$have_attr_iaso" = x"yes" ; then
-    AC_DEFINE([ATTR_INLINE_ALL_STRINGOPS],
-        [__attribute__ ((__target__ ("inline-all-stringops")))],
+    AC_DEFINE([ATTR_INLINE_ALL_STRINGOPS], [__attribute__ ((__target__ ("inline-all-stringops")))],
+        [Define this to a function attribute that inlines string handling code])
+else
+    AC_DEFINE([ATTR_INLINE_ALL_STRINGOPS], [],
         [Define this to a function attribute that inlines string handling code])
 fi
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-30 02:14:14 UTC
(In reply to ernsteiswuerfel from comment #5)
> Erm, I meant 0.99.12 builds fine...
> 
> There was already an upstream issue posted about this
> (https://sourceforge.net/p/xine/tickets/10/). Also the mentioned patch at
> https://sourceforge.net/p/xine/xine-ui/ci/
> f9a98e02460348ca23ca2f5c2b39e62c8758b22d/ works and 0.99.13.
> 
> Though it seems you only need the 1st part of the patch to make 0.99.13
> build on ppc64:
> 
> --- a/configure.ac	2021-12-12 20:49:29.000000000 +0100
> +++ b/configure.ac	2022-09-21 14:41:38.245392764 +0200
> @@ -600,8 +600,10 @@
>  ])], [have_attr_iaso=yes], [have_attr_iaso=no])
>  AC_MSG_RESULT([$have_attr_iaso])
>  if test x"$have_attr_iaso" = x"yes" ; then
> -    AC_DEFINE([ATTR_INLINE_ALL_STRINGOPS],
> -        [__attribute__ ((__target__ ("inline-all-stringops")))],
> +    AC_DEFINE([ATTR_INLINE_ALL_STRINGOPS], [__attribute__ ((__target__
> ("inline-all-stringops")))],
> +        [Define this to a function attribute that inlines string handling
> code])
> +else
> +    AC_DEFINE([ATTR_INLINE_ALL_STRINGOPS], [],
>          [Define this to a function attribute that inlines string handling
> code])
>  fi

Thank you!
Comment 7 Larry the Git Cow gentoo-dev 2022-09-30 02:14:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a0da2bafd776dfc30935a497316ec668a10aa24

commit 7a0da2bafd776dfc30935a497316ec668a10aa24
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-30 02:14:17 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-30 02:14:26 +0000

    media-video/xine-ui: backport build fix patch
    
    Closes: https://bugs.gentoo.org/871951
    Signed-off-by: Sam James <sam@gentoo.org>

 .../xine-ui/files/xine-ui-0.99.13-build.patch      | 43 ++++++++++++++++++++++
 media-video/xine-ui/xine-ui-0.99.13.ebuild         |  1 +
 2 files changed, 44 insertions(+)