Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 870595 - dev-ros/pr2_description-1.13.0 fails tests (lto): test_urdf.cpp:51:10: fatal error: urdf_parser.h: No such file or directory
Summary: dev-ros/pr2_description-1.13.0 fails tests (lto): test_urdf.cpp:51:10: fatal ...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robot Operating System team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-17 06:13 UTC by Agostino Sarubbo
Modified: 2024-04-05 02:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,398.01 KB, text/plain)
2022-09-17 06:13 UTC, Agostino Sarubbo
Details
1-LastTest.log (1-LastTest.log,2.36 KB, text/plain)
2022-09-17 06:13 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-17 06:13:00 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-ros/pr2_description-1.13.0 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-17 06:13:02 UTC
Created attachment 806779 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-09-17 06:13:03 UTC
Created attachment 806782 [details]
1-LastTest.log

1-LastTest.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-09-17 06:13:05 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


	  1 - _ctest_pr2_description_gtest_test_urdf (Failed)
/var/tmp/portage/dev-ros/pr2_description-1.13.0/work/pr2_common-1.13.0/pr2_description/test/test_urdf.cpp:51:10: fatal error: urdf_parser/urdf_parser.h: No such file or directory
FAILED: CMakeFiles/test_urdf.dir/test/test_urdf.cpp.o 
/var/tmp/portage/dev-ros/pr2_description-1.13.0/work/pr2_common-1.13.0/pr2_description/test/test_urdf.cpp:51:10: fatal error: urdf_parser/urdf_parser.h: No such file or directory
Comment 4 Jakov Smolić archtester gentoo-dev 2023-01-24 20:38:49 UTC
Package removed.