Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 870019 - meson.eclass: Consider setting -Dauto_features to avoid automagic dependencies
Summary: meson.eclass: Consider setting -Dauto_features to avoid automagic dependencies
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-13 19:22 UTC by Haelwenn (lanodan) Monnier
Modified: 2023-09-19 14:32 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Haelwenn (lanodan) Monnier 2022-09-13 19:22:48 UTC
> If the value of a feature option is set to auto, that value is overridden by the global auto_features option (which defaults to auto). This is intended to be used by packagers who want to have full control on which dependencies are required and which are disabled, and not rely on build-deps being installed (at the right version) to get a feature enabled. They could set auto_features=enabled to enable all features and disable explicitly only the few they don't want, if any.
> This type is available since version 0.47.0

I think it would be useful to make use of it in the eclass, maybe as a warning when unset for current EAPIs and set to -Dauto_features=enabled by default for next EAPIs.

This way it would avoid breaking ebuilds (ie. for libsoup this would hard-require autobahn and quart for tests, latter being absent from gentoo repo).
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-13 19:25:50 UTC
Yeah, I think being explicit is generally a good idea, especially as it guards us against changing defaults in both directions.
Comment 2 Larry the Git Cow gentoo-dev 2023-09-19 14:32:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8b1853847b46f9b314edb026b9e692f9b3787415

commit 8b1853847b46f9b314edb026b9e692f9b3787415
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2022-09-13 19:40:17 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-09-19 14:31:58 +0000

    net-libs/libsoup: Fix automagic test dependencies
    
    Bug: https://bugs.gentoo.org/870019
    Closes: https://github.com/gentoo/gentoo/pull/27241
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-libs/libsoup/libsoup-2.74.3.ebuild | 3 +++
 net-libs/libsoup/libsoup-3.4.2.ebuild  | 4 ++++
 net-libs/libsoup/libsoup-3.4.3.ebuild  | 4 ++++
 3 files changed, 11 insertions(+)