Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869128 - sys-libs/ncurses: does not set -D_XOPEN_SOURCE=600 on musl (was: app-crypt/pinentry-1.2.1: pinentry-curses.c:651:8: error: call to undeclared function 'addnwstr' (implicit function declaration))
Summary: sys-libs/ncurses: does not set -D_XOPEN_SOURCE=600 on musl (was: app-crypt/pi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://marc.info/?l=ncurses-bug&m=16...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: systemwide-clang musl-porting
  Show dependency tree
 
Reported: 2022-09-07 23:19 UTC by Sam James
Modified: 2022-09-13 14:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (file_869128.txt,13.52 KB, text/plain)
2022-09-07 23:19 UTC, Sam James 		Details
config.log (file_869128.txt,56.86 KB, text/plain)
2022-09-07 23:19 UTC, Sam James 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-07 23:19:33 UTC 
Created attachment 803839 [details]
build.log

clang -DHAVE_CONFIG_H -I. -I..   -I../secmem -Wall -I/usr/include/ncursesw  -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -Wall -Wno-pointer-sign -Wpointer-arith -c -o libpinentry_curses_a-pinentry-curses.o `test -f 'pinentry-curses.c' || echo './'`pinentry-curses.c
pinentry-curses.c:651:8: error: call to undeclared function 'addnwstr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
              ADDCH (start[i]);
              ^
pinentry-curses.c:283:18: note: expanded from macro 'ADDCH'
#define ADDCH(x) addnwstr (&x, 1);
                 ^
pinentry-curses.c:651:8: note: did you mean 'addnstr'?
pinentry-curses.c:283:18: note: expanded from macro 'ADDCH'
#define ADDCH(x) addnwstr (&x, 1);
                 ^
/usr/include/ncursesw/curses.h:609:28: note: 'addnstr' declared here
extern NCURSES_EXPORT(int) addnstr (const char *, int);                 /* generated */
                           ^
pinentry-curses.c:654:6: error: call to undeclared function 'addnwstr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            ADDCH (start[len - 1]);
            ^
pinentry-curses.c:283:18: note: expanded from macro 'ADDCH'
#define ADDCH(x) addnwstr (&x, 1);
                 ^
pinentry-curses.c:687:7: error: call to undeclared function 'addnwstr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                    ADDCH (*p);
                    ^
pinentry-curses.c:283:18: note: expanded from macro 'ADDCH'
#define ADDCH(x) addnwstr (&x, 1);
                 ^
pinentry-curses.c:724:8: error: call to undeclared function 'addnwstr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
              ADDCH (*(p++));
              ^
pinentry-curses.c:283:18: note: expanded from macro 'ADDCH'
#define ADDCH(x) addnwstr (&x, 1);
                 ^
4 errors generated.
make[2]: *** [Makefile:473: libpinentry_curses_a-pinentry-curses.o] Error 1
make[2]: *** Waiting for unfinished jobs....

----

# emerge --info
!!! No gcc found. You probably need to 'source /etc/profile'
!!! to update the environment of this terminal and possibly
!!! other terminals also.
Portage 3.0.30 (python 3.10.7-final-0, default/linux/amd64/17.0/musl/clang, [unavailable], musl-1.2.3, 5.15.65-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.15.65-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-libc
KiB Mem:    65765040 total,  31412412 free
KiB Swap:    8290300 total,   8224508 free
Timestamp of repository gentoo: Wed, 07 Sep 2022 19:57:30 +0000
sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           3.10.7::gentoo, 3.11.0_rc1_p2::gentoo
dev-util/cmake:            3.23.3::gentoo
dev-util/meson:            0.62.2::gentoo
sys-apps/baselayout:       2.8-r2::gentoo
sys-apps/openrc:           0.44.10::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo, 15.0.0::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.6::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.0::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.19::gentoo (virtual/os-headers)
sys-libs/musl:             1.2.3::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
ADDR2LINE="llvm-addr2line"
AR="llvm-ar"
AS="llvm-as"
CBUILD="x86_64-gentoo-linux-musl"
CC="clang"
CFLAGS="-O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="x86_64-gentoo-linux-musl"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXX="clang++"
CXXFLAGS="-O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="charset.alias /usr/share/locale/locale.alias"
LANG="C.UTF8"
LD="ld.lld"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -fuse-ld=lld -rtlib=compiler-rt -unwindlib=libunwind -Wl,--as-needed  -Wl,--defsym=__gentoo_check_ldflags__=0"
NM="llvm-nm"
OBJCOPY="llvm-objcopy"
OBJDUMP="llvm-objdump"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="llvm-ranlib"
READELF="llvm-readelf"
STRINGS="llvm-strings"
STRIP="llvm-strip"
USE="acl amd64 bzip2 clang cli crypt dri fortran iconv ipv6 libglvnd libtirpc ncurses nls nptl pam pcre readline seccomp split-usr ssl unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="musl" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ARFLAGS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, MAKEOPTS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS, SHELL, SIZE, YACC, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-07 23:19:42 UTC 
Created attachment 803842 [details]
config.log
Comment 2 Larry the Git Cow gentoo-dev 2022-09-09 11:19:04 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=345696eea0fbeb96946f1c1ae7293150c2c7e8ad

commit 345696eea0fbeb96946f1c1ae7293150c2c7e8ad
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-09 06:09:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-09 11:18:53 +0000

    sys-libs/ncurses: add 6.3_p20220903, use -D_XOPEN_SOURCE=600 on musl (fix ncursesw usage)
    
    Before, `pkg-config --cflags ncurses` would not include -D_XOPEN_SOURCE=600
    and then various unicode/wide definitions would not be exposed.
    
    Closes: https://bugs.gentoo.org/869128
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/ncurses/Manifest                        |   3 +
 sys-libs/ncurses/ncurses-6.3_p20220903-r1.ebuild | 437 +++++++++++++++++++++++
 sys-libs/ncurses/ncurses-6.3_p20220903.ebuild    | 435 ++++++++++++++++++++++
 3 files changed, 875 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-09-09 12:34:26 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7a6f1a26fae20fe511f05ac09702ed3c94da6fb

commit b7a6f1a26fae20fe511f05ac09702ed3c94da6fb
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-09 12:32:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-09 12:34:12 +0000

    sys-libs/ncurses: use hosted patchset for 6.3_p20220903
    
    This is needed because we really want the full generated
    configure files in addition to the source (configure.in
    changes).
    
    It's far too hard to rebase and also ensure
    the patches are doing what they're supposed
    to if just relying on patches to a huge
    configure script.
    
    Rebase the whole lot, and then throw in
    the patch for bug 869128 from 345696eea0fbeb96946f1c1ae7293150c2c7e8ad.
    
    Closes: https://bugs.gentoo.org/869128
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/ncurses/Manifest                        |  2 +-
 sys-libs/ncurses/ncurses-6.3_p20220903-r1.ebuild | 44 ++++++++++++-----------
 sys-libs/ncurses/ncurses-6.3_p20220903.ebuild    | 46 +++++++++++++-----------
 3 files changed, 50 insertions(+), 42 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-09-11 14:50:24 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1be1b68719135411b81319ccf58959974b00c03

commit c1be1b68719135411b81319ccf58959974b00c03
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-11 14:45:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-11 14:49:33 +0000

    sys-libs/ncurses: add 6.3_p20220910
    
    This contains an upstream fix for the musl issue.
    
    Closes: https://bugs.gentoo.org/869128
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/ncurses/Manifest                        |   3 +
 sys-libs/ncurses/ncurses-6.3_p20220910-r1.ebuild | 447 +++++++++++++++++++++++
 sys-libs/ncurses/ncurses-6.3_p20220910.ebuild    | 447 +++++++++++++++++++++++
 3 files changed, 897 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-09-13 14:32:49 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d46d566162258c1f1ab8411803e8800a5545424

commit 2d46d566162258c1f1ab8411803e8800a5545424
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-13 14:25:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-13 14:26:37 +0000

    net-misc/suite3270: add 4.2_p5
    
    Also ports ncurses detection to pkg-config to fix build on musl
    (need -DNCURSES_WIDECHAR definition).
    
    The issue is observable with Clang 15 as it throws up
    implicit. decl errors.
    
    Bug: https://bugs.gentoo.org/869128
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/suite3270/Manifest                        |   1 +
 .../suite3270/files/suite3270-4.2_p5-egrep.patch   |  21 ++++
 .../suite3270-4.2_p5-ncurses-pkg-config.patch      |  48 ++++++++++
 net-misc/suite3270/suite3270-4.2_p5.ebuild         | 106 +++++++++++++++++++++
 4 files changed, 176 insertions(+)