https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-libs/libmateweather-1.26.0 fails tests (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 801763 [details] build.log build log and emerge --info
I'm seeing this test failure on a non-LTO system. To save anyone having to dig through the attachment, the failing command is "./check-timezones.sh ./Locations.xml.in" in $S/data, and the error message is "Invalid timezones in ./Locations.xml.in: Europe/Kiev". I also found this in the Debian bug database, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017304 . According to that bug thread, this is because in timezone-data-2022b Kiev was renamed to Kyiv; that Debian bug also includes a patch claimed to fix this failure.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0f22fafca63f78e83823ee61bceefed750b36d7 commit d0f22fafca63f78e83823ee61bceefed750b36d7 Author: Ian Jordan <immoloism@gmail.com> AuthorDate: 2023-12-22 15:46:42 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-01 20:34:23 +0000 dev-libs/libmateweather: add 1.26.2, 1.27.1 Tests pass on both versions fixing #867271 Bumped versions fix missing weather data #917271 Closes: https://bugs.gentoo.org/916271 Closes: https://bugs.gentoo.org/867271 Signed-off-by: Ian Jordan <immoloism@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/libmateweather/Manifest | 2 + .../libmateweather/libmateweather-1.26.2.ebuild | 48 ++++++++++++++++++++++ .../libmateweather/libmateweather-1.27.1.ebuild | 48 ++++++++++++++++++++++ 3 files changed, 98 insertions(+)
