Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 866398 - sys-libs/ncurses: Unprefixed invocations of ld and pkg-config
Summary: sys-libs/ncurses: Unprefixed invocations of ld and pkg-config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2022-08-24 20:00 UTC by Allen Webb
Modified: 2022-08-29 19:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Webb 2022-08-24 20:00:06 UTC
On ChromeOS we ran into unprefixed calls to ld and pkg-config. We resolved them by adding the following to src_prepare:

```
	sed -i -e 's/ld --verbose/${LD} --verbose/g' configure
	sed -i -e 's/pkg-config --version/${PKG_CONFIG} --version/g' misc/gen-pkgconfig.in
```

See: https://chromium-review.googlesource.com/c/chromiumos/overlays/portage-stable/+/3827661/comments/b3ab9cef_df7cef2b

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2022-08-24 20:10:32 UTC
You should really report this upstream, ideally with a patch.
Comment 2 Mike Gilbert gentoo-dev 2022-08-24 20:14:30 UTC
(upstream meaning the ncurses project, not Gentoo)
Comment 3 Allen Webb 2022-08-24 20:26:40 UTC
Sure, I will report it there as well, but I figured it made sense to report it here in case you want to apply the change until the ncurses maintainers resolve the issue.
Comment 4 Mike Gilbert gentoo-dev 2022-08-24 20:32:13 UTC
(In reply to Allen Webb from comment #3)

Sounds good, and thanks for the heads-up.
Comment 5 Allen Webb 2022-08-24 21:38:21 UTC
(In reply to Mike Gilbert from comment #4)
> (In reply to Allen Webb from comment #3)
> 
> Sounds good, and thanks for the heads-up.

Here is the upstream thread: https://lists.gnu.org/archive/html/bug-ncurses/2022-08/msg00024.html
Comment 6 Larry the Git Cow gentoo-dev 2022-08-26 06:36:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0703fef2220d392cd1b35fa8b02a0fb09826563

commit c0703fef2220d392cd1b35fa8b02a0fb09826563
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-08-26 06:20:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-26 06:35:39 +0000

    sys-libs/ncurses: don't call LD & pkg-config directly
    
    Bug: https://lists.gnu.org/archive/html/bug-ncurses/2022-08/msg00024.html
    Closes: https://bugs.gentoo.org/866398
    Thanks-to: Allen Webb <allenwebb@google.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/ncurses/ncurses-6.3_p20220423-r1.ebuild | 16 +++++++++++-----
 sys-libs/ncurses/ncurses-6.3_p20220423.ebuild    | 16 +++++++++++-----
 2 files changed, 22 insertions(+), 10 deletions(-)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-26 06:37:14 UTC
(In reply to Mike Gilbert from comment #4)
> (In reply to Allen Webb from comment #3)
> 
> Sounds good, and thanks for the heads-up.

Yeah, much appreciated. :)
Comment 8 Larry the Git Cow gentoo-dev 2022-08-29 19:06:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=be24fe0d566e4f4802370dfa69445c521e4e3340

commit be24fe0d566e4f4802370dfa69445c521e4e3340
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-08-29 18:50:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-29 18:56:04 +0000

    sys-libs/ncurses: add 6.3_p20220827
    
    Closes: https://bugs.gentoo.org/866398
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/ncurses/Manifest                        |   2 +
 sys-libs/ncurses/ncurses-6.3_p20220827-r1.ebuild | 420 +++++++++++++++++++++++
 sys-libs/ncurses/ncurses-6.3_p20220827.ebuild    | 418 ++++++++++++++++++++++
 3 files changed, 840 insertions(+)