Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 865347 - dev-util/buildbot-worker: need systemd service file
Summary: dev-util/buildbot-worker: need systemd service file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Brian Dolbec
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: install-systemd-unit
  Show dependency tree
 
Reported: 2022-08-16 01:35 UTC by yongxiang
Modified: 2022-09-23 03:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
systemd service file (buildbot_worker.service,296 bytes, text/x-dbus-service)
2022-08-18 00:22 UTC, Brian Dolbec (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description yongxiang 2022-08-16 01:35:59 UTC
Package doesn't appear to include one.

Archlinux should be using this https://github.com/buildbot/buildbot-contrib/blob/master/worker/contrib/systemd/buildbot-worker%40.service
Debian's service file is : https://salsa.debian.org/python-team/packages/buildbot/-/blob/debian/master/debian/buildbot-worker%40.service

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-16 01:44:24 UTC
pkg_postinst has:
>ewarn "Systems using systemd can do the following:"
>ewarn "    systemctl enable buildbot_worker@myinstance.service"
>ewarn "    systemctl enable buildbot_worker.target"
>ewarn "    systemctl start buildbot_worker.target"

and I swear I remember setting it up, but actually, I don't have one on my system, so you may be right. Huh.
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2022-08-18 00:22:26 UTC
Created attachment 799997 [details]
systemd service file
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2022-08-18 00:24:38 UTC
I knew I had one there at one time... looking at the logs...
Seems someone decided to nuke the systemd file:

author	Michael Mair-Keimberger <m.mairkeimberger@gmail.com>	2017-10-30 19:56:32 +0100
committer	Michael Palimaka <kensington@gentoo.org>	2017-11-04 18:25:05 +1100
commit	560c38149d3a99c88fa60ae444899c54657670fc (patch)


Sam, yongxiang, can you confirm that the original service file is still correct and I'll restore it.
Comment 4 yongxiang 2022-08-18 01:12:23 UTC
In buildbot_worker.service, command is "/usr/bin/buildbot_worker start /var/lib/buildbot_worker". And in buildbot-worker package is /usr/bin/buildbot-worker.
It also does not support starting multiple buildbot workers. I can't confirm that no --nodaemon argument is appropriate in systemd.

Just now I noticed another question, is /usr/bin/buildbot_worker_windows_service useful?

/usr/bin/buildbot_worker_windows_service --help
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.10/buildbot_worker_windows_service", line 5, in <module>
    from buildbot_worker.scripts.windows_service import HandleCommandLine
  File "/usr/lib/python3.10/site-packages/buildbot_worker/scripts/windows_service.py", line 77, in <module>
    import pywintypes
ModuleNotFoundError: No module named 'pywintypes'
Comment 5 yongxiang 2022-08-18 01:21:13 UTC
I added or not added --nodaemon to the service file and then systemd start seems to work fine.
Comment 6 Larry the Git Cow gentoo-dev 2022-08-25 23:24:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4714c80b46cdb669f1e02e11524cf80a518b30f6

commit 4714c80b46cdb669f1e02e11524cf80a518b30f6
Author:     Brian Dolbec <dolsen@gentoo.org>
AuthorDate: 2022-08-18 00:20:04 +0000
Commit:     Brian Dolbec <dolsen@gentoo.org>
CommitDate: 2022-08-25 23:24:08 +0000

    dev-util/buildbot-worker: Revert "dev-util/buildbot-worker: remove unused service file"
    
    This reverts commit 560c38149d3a99c88fa60ae444899c54657670fc.
    
    Closes: https://bugs.gentoo.org/865347
    Signed-off-by: Brian Dolbec <dolsen@gentoo.org>

 dev-util/buildbot-worker/files/buildbot_worker.service | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Comment 7 Ionen Wolkens gentoo-dev 2022-08-26 00:24:22 UTC
The file is still unused, the ebuild doesn't install it that I can see. That's why it was removed like any other unused files.
Comment 8 Brian Dolbec (RETIRED) gentoo-dev 2022-08-27 02:47:43 UTC
(In reply to Ionen Wolkens from comment #7)
> The file is still unused, the ebuild doesn't install it that I can see.
> That's why it was removed like any other unused files.

thank you.  I'll fix it then
Comment 9 Brian Dolbec (RETIRED) gentoo-dev 2022-09-23 03:06:09 UTC
New service files added in the 3.6.1 release.

These copy the service files from buildbot master (provided by others) that should be able to handle multiple workers on the same system.

Please test and report any bugs/fixes needed as I do not have any systemd systems, nor do I know systemd.


I also added a sed to the ebuild to remove the windows start script from being installed.