Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 864815 - emirrordist ignores FETCHCOMMAND and uses hardwired insecure wget
Summary: emirrordist ignores FETCHCOMMAND and uses hardwired insecure wget
Status: UNCONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-10 16:43 UTC by emdee_is
Modified: 2023-08-30 14:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description emdee_is 2022-08-10 16:43:15 UTC
emerge ignores FETCHCOMMAND and uses insecure wget: in 
site-packages/portage/_emirrordist/FetchTask.py
Line 24 it defines default_fetchcommand as 
 'wget -c -v -t 1 --passive-ftp --no-check-certificate --timeout=60 -O "${DISTDIR}/${FILE}" "${URI}"'
and uses it with checking FETCHCOMMAND at line 487.

FETCHCOMMAND may be required for special proxy or security settings, and it is not nice to use --no-check-certificate hardwired without the user knowing or able to configure it.
Comment 1 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-08-10 16:52:16 UTC
(In reply to emdee_is from comment #0)
> emerge ignores FETCHCOMMAND and uses insecure wget: in 
> site-packages/portage/_emirrordist/FetchTask.py

Is code from that file executed via emerge?
Comment 2 Mike Gilbert gentoo-dev 2022-08-10 17:04:22 UTC
(In reply to John Helmert III from comment #1)

As far as I can tell, this is only relevant for people using the emirrordist script to replicate distfiles.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-10 17:51:50 UTC
Note that while this is still likely worth fixing:
1. you couldn't ever really force pure HTTPS when running emirrordist (the origin SRC_URI is what it is, you can't magically *make* it HTTPS);
2. it's comparing against Manifest anyway;
3. generally, mirrors running emirrordist are not a secret. But I accept that it's silly to force some of this.

Please keep in mind this has *no bearing at all* on normal Portage operation.