Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 864531 - media-libs/libva-intel-media-driver-22.5.4 fails to compile (lto): codechal_encode_mpeg2_g8.cpp:30: error: type struct KernelHeader violates the C++ One Definition Rule [-Werror=odr]
Summary: media-libs/libva-intel-media-driver-22.5.4 fails to compile (lto): codechal_e...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: VA-API Project
URL: https://github.com/intel/media-driver...
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-09 07:08 UTC by Agostino Sarubbo
Modified: 2023-08-02 11:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,57.25 KB, application/x-xz)
2022-08-09 07:08 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-09 07:08:05 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-libs/libva-intel-media-driver-22.5.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-09 07:08:13 UTC
Created attachment 798955 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-09 07:08:15 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: media_driver/iHD_drv_video.so 
fatal: not a git repository (or any parent up to mount point /var/tmp)
/var/tmp/portage/x11-libs/libva-intel-media-driver-22.5.1/work/media-driver-intel-media-22.5.1/media_driver/agnostic/gen8/codec/hal/codechal_encode_mpeg2_g8.cpp:30: error: type ‘struct KernelHeader’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Agostino Sarubbo gentoo-dev 2022-10-17 13:37:27 UTC
lto_tinderbox has reproduced this issue with version 22.5.4 - Updating summary.
Comment 4 Kostadin Shishmanov 2023-08-02 11:30:13 UTC
I think this can be closed, considering that both of the versions in the tree have the fix merged upstream.