https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sci-visualization/paraview-5.10.1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 797170 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/CMakeFiles/xdmf2.dir/XdmfExprLex.cxx.o /var/tmp/portage/sci-visualization/paraview-5.10.1/work/ParaView-v5.10.1/VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfExprLex.cxx:558:11: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
lto_tinderbox has reproduced this issue with version 5.11.0_rc2 - Updating summary.
At this size of a code base I think this is impossible to fix downstream. There are even a substantial number of very fundamental -Werror=incompatible-function-pointer-types issues in the code base.
(In reply to Matthias Maier from comment #4) > At this size of a code base I think this is impossible to fix downstream. > There are even a substantial number of very fundamental > -Werror=incompatible-function-pointer-types issues in the code base. That's fine, just filter-lto & append-flags -fno-strict-aliasing.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=587f35adb343929c5f2db2e2a41ef02e4906ad79 commit 587f35adb343929c5f2db2e2a41ef02e4906ad79 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2023-04-20 04:23:43 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2023-04-20 19:47:30 +0000 sci-visualization/paraview: add 5.11.1 Closes: https://bugs.gentoo.org/847379 Closes: https://bugs.gentoo.org/863299 Closes: https://bugs.gentoo.org/890493 Closes: https://bugs.gentoo.org/897246 Signed-off-by: Matthias Maier <tamiko@gentoo.org> sci-visualization/paraview/Manifest | 1 + sci-visualization/paraview/paraview-5.11.1.ebuild | 236 ++++++++++++++++++++++ 2 files changed, 237 insertions(+)
