Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 863224 - dev-qt/qttools: could use some IUSE defaults (perhaps more qt6 packages too)
Summary: dev-qt/qttools: could use some IUSE defaults (perhaps more qt6 packages too)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 838970
  Show dependency tree
 
Reported: 2022-08-03 02:05 UTC by Ionen Wolkens
Modified: 2023-06-10 14:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ionen Wolkens gentoo-dev 2022-08-03 02:05:39 UTC
I know it's not entirely decided how to handle this package (aka possible split), but if kept like this, at least IUSE="+linguist +designer" be nice

For PyQt6 I ended up needing this:
    designer? ( >=dev-qt/qttools-${QT_PV}[designer] )
    help? ( >=dev-qt/qttools-${QT_PV}[assistant] )
(formerly just depended on qttools pre-USE)

And then was about to add qttools[linguist] to pcsx2. But none of these are default and finding myself having to set USE often so far.
Comment 1 Davide Pesavento gentoo-dev 2022-08-03 05:03:06 UTC
(In reply to Ionen Wolkens from comment #0)
> For PyQt6 I ended up needing this:
>     designer? ( >=dev-qt/qttools-${QT_PV}[designer] )
>     help? ( >=dev-qt/qttools-${QT_PV}[assistant] )
This is not a good reason for adding IUSE defaults. 'designer' especially should be very rarely needed. 'linguist' _probably_ makes more sense to enable by default.

But IMHO, all of this is just another reason to split the package.
Comment 2 Ionen Wolkens gentoo-dev 2022-08-03 12:15:52 UTC
wrt designer it wasn't because of that, it's because qttools has:

REQUIRED_USE="linguist? ( designer )"

So unless want almost every users to set both (because I assume linguist will be used a lot), it should be either default or split.
Comment 3 Davide Pesavento gentoo-dev 2022-08-03 17:01:14 UTC
(In reply to Ionen Wolkens from comment #2)
> wrt designer it wasn't because of that, it's because qttools has:
> 
> REQUIRED_USE="linguist? ( designer )"
> 
Oh ok, that makes more sense then.

But that REQUIRED_USE smells very fishy to me. I believe it's just the linguist GUI app that needs the designer components, and very few users need the GUI app. So, even if qttools isn't split, there should be separate flags for the app vs the command-line tools (such as lrelease).
Comment 4 Chiitoo gentoo-dev 2022-10-16 14:44:43 UTC
(In reply to Davide Pesavento from comment #3)
> (In reply to Ionen Wolkens from comment #2)
> > wrt designer it wasn't because of that, it's because qttools has:
> > 
> > REQUIRED_USE="linguist? ( designer )"
> > 
> Oh ok, that makes more sense then.
> 
> But that REQUIRED_USE smells very fishy to me. I believe it's just the
> linguist GUI app that needs the designer components, and very few users need
> the GUI app. So, even if qttools isn't split, there should be separate flags
> for the app vs the command-line tools (such as lrelease).

I can't remember the reason for that.

I did find f865a701255 [1], but it's a liiittle bit ancient.  :V

A build with "linguist -designer" seems OK so far, so I'll go ahead and get rid of that required use, and /maybe/ make linguist default.

1. https://code.qt.io/cgit/qt/qttools.git/commit/?h=6.4&id=f865a7012559b10f39cbc58f1d3d7fa92ae6de5b
Comment 5 Ionen Wolkens gentoo-dev 2022-10-16 14:53:05 UTC
Ultimately this bug was going to become obsolete when qttools is split, although until then I think default linguist makes sense.
Comment 6 Chiitoo gentoo-dev 2022-10-16 15:05:33 UTC
Yeah, I keep hoping I'll get to the splitting soon (tm).
Comment 7 Larry the Git Cow gentoo-dev 2022-10-16 15:14:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=a22b3b6f4b215d2ed1462f2357feb7053b8cfed7

commit a22b3b6f4b215d2ed1462f2357feb7053b8cfed7
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2022-10-16 14:59:39 +0000
Commit:     Jimi Huotari <chiitoo@gentoo.org>
CommitDate: 2022-10-16 15:13:12 +0000

    dev-qt/qttools: remove a required use and make 'linguist' default on
    
    There seems to be no apparent reason for
    'REQUIRED_USE="linguist? ( designer )"', and the origins of it have
    been lost in time.
    
    Furthermore, the 'linguist' flag may usually be more wanted than not,
    so we'll enable it by default.
    
    Bug: https://bugs.gentoo.org/863224
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>

 dev-qt/qttools/qttools-6.4.0.ebuild    | 3 +--
 dev-qt/qttools/qttools-6.4.9999.ebuild | 3 +--
 dev-qt/qttools/qttools-6.9999.ebuild   | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)
Comment 8 Chiitoo gentoo-dev 2022-10-16 16:38:57 UTC
(In reply to Chiitoo from comment #4)
> (In reply to Davide Pesavento from comment #3)
> > (In reply to Ionen Wolkens from comment #2)
> > > wrt designer it wasn't because of that, it's because qttools has:
> > > 
> > > REQUIRED_USE="linguist? ( designer )"
> > > 
> > Oh ok, that makes more sense then.
> > 
> > But that REQUIRED_USE smells very fishy to me. I believe it's just the
> > linguist GUI app that needs the designer components, and very few users need
> > the GUI app. So, even if qttools isn't split, there should be separate flags
> > for the app vs the command-line tools (such as lrelease).
> 
> I can't remember the reason for that.

Oh, just noticed that 'linguist:5' has the following, which I imagine I was looking at when adding the above:

[...]
DEPEND="
    =dev-qt/designer-${QT5_PV}*
[...]
Comment 9 Larry the Git Cow gentoo-dev 2022-11-02 05:10:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2b15ca2f28c0decd82dff7167b73a455ac1c7b1

commit c2b15ca2f28c0decd82dff7167b73a455ac1c7b1
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2022-10-14 15:30:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-02 05:09:45 +0000

    dev-qt/*: add version 6.4.0
    
    Bug: https://bugs.gentoo.org/838970
    Bug: https://bugs.gentoo.org/863224
    Bug: https://bugs.gentoo.org/875956
    Closes: https://bugs.gentoo.org/862525
    Closes: https://bugs.gentoo.org/863395
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/27812
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-qt/qt5compat/Manifest                          |   1 +
 dev-qt/qt5compat/qt5compat-6.4.0.ebuild            |  18 ++
 dev-qt/qtbase/Manifest                             |   1 +
 dev-qt/qtbase/qtbase-6.4.0.ebuild                  | 185 ++++++++++++++++
 dev-qt/qtcharts/Manifest                           |   1 +
 dev-qt/qtcharts/qtcharts-6.4.0.ebuild              |  18 ++
 dev-qt/qtdeclarative/Manifest                      |   1 +
 dev-qt/qtdeclarative/qtdeclarative-6.4.0.ebuild    |  30 +++
 dev-qt/qtimageformats/Manifest                     |   1 +
 dev-qt/qtimageformats/qtimageformats-6.4.0.ebuild  |  35 +++
 dev-qt/qtmultimedia/Manifest                       |   1 +
 dev-qt/qtmultimedia/qtmultimedia-6.4.0.ebuild      |  42 ++++
 dev-qt/qtnetworkauth/Manifest                      |   1 +
 dev-qt/qtnetworkauth/qtnetworkauth-6.4.0.ebuild    |  17 ++
 dev-qt/qtpositioning/Manifest                      |   1 +
 dev-qt/qtpositioning/qtpositioning-6.4.0.ebuild    |  19 ++
 dev-qt/qtquick3d/Manifest                          |   1 +
 dev-qt/qtquick3d/qtquick3d-6.4.0.ebuild            |  32 +++
 dev-qt/qtquicktimeline/Manifest                    |   1 +
 .../qtquicktimeline/qtquicktimeline-6.4.0.ebuild   |  18 ++
 dev-qt/qtserialport/Manifest                       |   1 +
 dev-qt/qtserialport/qtserialport-6.4.0.ebuild      |  18 ++
 dev-qt/qtshadertools/Manifest                      |   1 +
 dev-qt/qtshadertools/qtshadertools-6.4.0.ebuild    |  17 ++
 dev-qt/qtsvg/Manifest                              |   1 +
 dev-qt/qtsvg/qtsvg-6.4.0.ebuild                    |  18 ++
 dev-qt/qttools/Manifest                            |   1 +
 .../files/qttools-6.4.0-clang-15-build.patch       |  73 ++++++
 dev-qt/qttools/qttools-6.4.0.ebuild                |  55 +++++
 dev-qt/qtwayland/Manifest                          |   1 +
 dev-qt/qtwayland/qtwayland-6.4.0.ebuild            |  22 ++
 dev-qt/qtwebchannel/Manifest                       |   1 +
 dev-qt/qtwebchannel/qtwebchannel-6.4.0.ebuild      |  19 ++
 dev-qt/qtwebengine/Manifest                        |   1 +
 .../qtwebengine-6.4.0-no-websocket-intercept.patch |  38 ++++
 dev-qt/qtwebengine/qtwebengine-6.4.0.ebuild        | 245 +++++++++++++++++++++
 dev-qt/qtwebsockets/Manifest                       |   1 +
 dev-qt/qtwebsockets/qtwebsockets-6.4.0.ebuild      |  18 ++
 38 files changed, 955 insertions(+)
Comment 10 Chiitoo gentoo-dev 2023-06-10 14:39:43 UTC
Use 'linguist' has been enabled by default for a while now, and we can add more if need be later.

The split isn't happening right now either, so let's go with what we have for now.

Thank you!