Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862753 - sci-libs/givaro-4.1.1-r2 installs pkg-config files that do not respect libdir
Summary: sci-libs/givaro-4.1.1-r2 installs pkg-config files that do not respect libdir
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: pkg-config_mismatched-libdir
  Show dependency tree
 
Reported: 2022-08-01 08:06 UTC by Agostino Sarubbo
Modified: 2022-09-02 11:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,121.65 KB, text/plain)
2022-08-01 08:06 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-01 08:06:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/givaro-4.1.1-r2 installs pkg-config files that do not respect libdir.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-01 08:06:05 UTC
Created attachment 796492 [details]
build.log

build log and emerge --info
Comment 2 François Bissey 2022-08-01 08:16:58 UTC
I can clearly see the issue being still present upstream. I'll open an issue there. That's an easy patch if annoying.
Comment 3 François Bissey 2022-08-01 08:24:20 UTC
https://github.com/linbox-team/givaro/issues/200
Comment 4 Larry the Git Cow gentoo-dev 2022-09-02 11:11:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6bc01c6dc39ae282df30c969c06e39b5751db32

commit f6bc01c6dc39ae282df30c969c06e39b5751db32
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2022-09-02 11:06:36 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2022-09-02 11:09:04 +0000

    sci-libs/givaro: fix pkg-config libdir, update EAPI 7 -> 8
    
    Apply François Bissey's upstream patch in a new revision.
    
    Closes: https://bugs.gentoo.org/862753
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 .../givaro/files/givaro-4.1.1-fix-pc-libdir.patch  | 21 ++++++++
 sci-libs/givaro/givaro-4.1.1-r3.ebuild             | 59 ++++++++++++++++++++++
 2 files changed, 80 insertions(+)