https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sci-libs/fflas-ffpack-2.4.3-r2 installs pkg-config files that do not respect libdir. Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 796486 [details] build.log build log and emerge --info
Still there upstream like givaro. Funny, linbox which share the same upstream as this one and givaro, does respect libdir.
https://github.com/linbox-team/fflas-ffpack/issues/364
There is a funny bit about that particular one. `libdir` is indeed set wrong. But it is not actively used. `Libs` is actually set with other variables that happen to have the right value. So, while `libdir` is incorrect `Libs` is. On my system prefix=/usr exec_prefix=/usr libdir=/usr/lib includedir=/usr/include Name: fflas-ffpack Description: Finite Field Linear Algebra Suroutines/Package URL: http://github.com/linbox-team/fflas-ffpack Version: 2.4.3 Requires: givaro >= 4.0.3 Libs: -fopenmp -L/usr/lib64 -lfflas -lffpack -lcblas -lblas Cflags: -I${prefix}/include -fopenmp -DFFLAS_COMPILED -DFFPACK_COMPILED $ pkgconf --libs-only-L --keep-system-libs fflas-ffpack -L/usr/lib64
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6e742b3835750d6992128d07b34165f65a57818 commit d6e742b3835750d6992128d07b34165f65a57818 Author: Michael Orlitzky <mjo@gentoo.org> AuthorDate: 2022-09-02 11:17:53 +0000 Commit: Michael Orlitzky <mjo@gentoo.org> CommitDate: 2022-09-02 11:28:07 +0000 sci-libs/fflas-ffpack: fix pkg-config libdir, update EAPI 7 -> 8 Apply François Bissey's upstream patch in a new revision. Closes: https://bugs.gentoo.org/862747 Signed-off-by: Michael Orlitzky <mjo@gentoo.org> sci-libs/fflas-ffpack/fflas-ffpack-2.4.3-r3.ebuild | 75 ++++++++++++++++++++++ .../files/fflas-ffpack-2.4.3-fix-pc-libdir.patch | 21 ++++++ 2 files changed, 96 insertions(+)
