https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sci-libs/cdf-3.8.0-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 796417 [details] build.log build log and emerge --info
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e1d16eb94174d187d5db3417b786f476f78efeb commit 3e1d16eb94174d187d5db3417b786f476f78efeb Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-22 07:10:53 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-22 07:11:55 +0000 sci-libs/cdf: add 3.9.0 Reported the aliasing issue upstream by email. Closes: https://bugs.gentoo.org/804951 Closes: https://bugs.gentoo.org/862675 Signed-off-by: Sam James <sam@gentoo.org> sci-libs/cdf/Manifest | 9 ++ sci-libs/cdf/cdf-3.9.0.ebuild | 148 +++++++++++++++++++++++ sci-libs/cdf/files/cdf-3.9.0-respect-flags.patch | 85 +++++++++++++ 3 files changed, 242 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30d13e67ffe6760317622fec3bf2379565546e71 commit 30d13e67ffe6760317622fec3bf2379565546e71 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-22 08:41:28 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-22 08:43:29 +0000 sci-libs/cdf: backport LTO filter to stable Closes: https://bugs.gentoo.org/927487 Bug: https://bugs.gentoo.org/862675 Signed-off-by: Sam James <sam@gentoo.org> sci-libs/cdf/cdf-3.8.0-r1.ebuild | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
