Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862606 - estrip: spurious "build-info/NEEDED: No such file or directory" message on < EAPI 7 ebuilds
Summary: estrip: spurious "build-info/NEEDED: No such file or directory" message on < ...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 859439 863803
  Show dependency tree
 
Reported: 2022-07-31 21:49 UTC by Sam James
Modified: 2022-08-23 00:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_862606.txt,1.79 KB, text/plain)
2022-07-31 21:49 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-31 21:49:37 UTC
Created attachment 796276 [details]
build.log

Can reproduce by sed EAPI 8 -> EAPI 6 in app-cdr/dvdshrink-2.6.1_p10-r1.

----
Portage 3.0.34_p16 (python 3.11.0-beta-5, default/linux/amd64/17.1/hardened, gcc-12.1.1, glibc-2.35-r8, 5.15.58-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.15.58-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.35
KiB Mem:    65765032 total,  19663800 free
KiB Swap:    8290300 total,   8290300 free
Timestamp of repository gentoo: Sun, 31 Jul 2022 19:46:43 +0000
Head commit of repository gentoo: d52699f22f12e3bb7980e217ec9d51785947c49f

Timestamp of repository kde: Sun, 31 Jul 2022 18:16:35 +0000
Head commit of repository kde: ddd6428e0368d4caa95deb2132efd8ddef9aa570

Timestamp of repository qt: Tue, 26 Jul 2022 05:02:11 +0000
Head commit of repository qt: 9335f9a7708c8c9feb104ebd20d3501c98bcac5a

Timestamp of repository sam_c: Thu, 28 Jul 2022 03:31:30 +0000
Head commit of repository sam_c: 204a9a77a9f7e457618ff7421cfcc782ffadca1b

Timestamp of repository steam-overlay: Tue, 26 Jul 2022 05:02:13 +0000
Head commit of repository steam-overlay: 3c317721662b38a969f6731777d6238b388912ed

sh dash 0.5.11.5
ld GNU ld (Gentoo 2.38 p4) 2.38
ccache version 4.6.1 [disabled]
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.2_rc2::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0::gentoo
dev-lang/python:           2.7.18_p15::gentoo, 3.8.13_p2::gentoo, 3.9.13::gentoo, 3.10.5::gentoo, 3.11.0_beta5::gentoo
dev-lang/rust:             1.62.1::gentoo
dev-util/ccache:           4.6.1::gentoo
dev-util/cmake:            3.23.3::gentoo
dev-util/meson:            0.63.0::gentoo
sys-apps/baselayout:       2.8-r2::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          251.3::gentoo
sys-devel/autoconf:        2.13-r2::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo
sys-devel/gcc:             11.3.1_p20220729::gentoo, 12.1.1_p20220730::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.6::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.18-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r8::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now
    sync-git-verify-commit-signature: yes

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo

test
    location: /var/db/repos/test
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -D_GLIBCXX_ASSERTIONS"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg cgroup clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
LINGUAS="en en_GB"
PKGDIR="/var/cache/binpkgs"
PORTAGE_COMPRESS="pzstd"
PORTAGE_COMPRESS_FLAGS="-9 --rm -q"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr clang crypt dbus declarative dist-kernel dri dts dvd dvdr emacs encode exif f16c filecaps firewalld flac fma3 freetype gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libglvnd libnotify libtirpc llvm-libunwind lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd threads tiff truetype udev udisks unicode upower usb verify-sig vorbis vulkan wayland widgets x264 xattr xcb xml xtpax xv xvid zfs zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10 pypy3 python3_11 python3_8 python3_9" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa m68k ppc64le sparc64" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-31 21:50:02 UTC
>>> Compiling source in /var/tmp/portage/app-cdr/dvdshrink-2.6.1_p10-r1/work/dvdshrink ...
>>> Source compiled.
>>> Test phase [not enabled]: app-cdr/dvdshrink-2.6.1_p10-r1

>>> Install app-cdr/dvdshrink-2.6.1_p10-r1 into /var/tmp/portage/app-cdr/dvdshrink-2.6.1_p10-r1/image/
>>> Completed installing app-cdr/dvdshrink-2.6.1_p10-r1 into /var/tmp/portage/app-cdr/dvdshrink-2.6.1_p10-r1/image/

 * Final size of build directory: 718 KiB
 * Final size of installed tree:   42 KiB

/home/sam/git/portage/bin/estrip: line 424: /var/tmp/portage/app-cdr/dvdshrink-2.6.1_p10-r1/build-info/NEEDED: No such file or directory
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-31 21:56:18 UTC
bb88e766897f5e7e0b0a10c48cf99a04edb73a40 is the first bad commit
commit bb88e766897f5e7e0b0a10c48cf99a04edb73a40
Author: Sam James <sam@gentoo.org>
Date:   Sat Mar 5 05:32:45 2022 +0000

    estrip: avoid calling scanelf twice

    We can use the previous scanelf data to not call it again to find
    all of the dynamically linked executables/libraries which need stripping.

    Bug: https://bugs.gentoo.org/749624
    Closes: https://github.com/gentoo/portage/pull/794
    Reviewed-by: Zac Medico <zmedico@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 bin/estrip            |  3 ++-
 bin/misc-functions.sh | 29 +++++++++++++++--------------
 2 files changed, 17 insertions(+), 15 deletions(-)

... which I figured, but what I don't get is why this doesn't happen with EAPI 8.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-31 22:05:47 UTC
(In reply to Sam James from comment #2)
> ... which I figured, but what I don't get is why this doesn't happen with
> EAPI 8.

Oh, EAPI 7+ introduced dostrip.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-31 23:09:00 UTC
(In reply to Sam James from comment #3)
> (In reply to Sam James from comment #2)
> > ... which I figured, but what I don't get is why this doesn't happen with
> > EAPI 8.
> 
> Oh, EAPI 7+ introduced dostrip.

I think the issue is that before dostrip, things were a lot messier with prepall, and the logic move doesn't really fit as it assumes things behave like estrip does, which is less fragile to order.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-31 23:58:33 UTC
Ah, I get it.
Comment 6 Larry the Git Cow gentoo-dev 2022-08-06 21:01:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=e8f0e06784549fc4c8a06e0a43ff946d6a895683

commit e8f0e06784549fc4c8a06e0a43ff946d6a895683
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-08-01 01:44:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-06 21:00:28 +0000

    estrip: apply scanelf optimisation to EAPI 7+ / dostrip
    
    (No need to do ${D%/} etc here as dostrip is in EAPI 7+ only.)
    
    See: bb88e766897f5e7e0b0a10c48cf99a04edb73a40
    Bug: https://bugs.gentoo.org/749624
    Bug: https://bugs.gentoo.org/862606
    Signed-off-by: Sam James <sam@gentoo.org>
    Closes: https://github.com/gentoo/portage/pull/879
    Signed-off-by: Sam James <sam@gentoo.org>

 bin/estrip | 41 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/proj/portage.git/commit/?id=7f6e83707daf4a7d8231b968078a1ba94d80c697

commit 7f6e83707daf4a7d8231b968078a1ba94d80c697
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-08-01 00:05:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-06 21:00:28 +0000

    estrip: avoid spurious NEEDED warning when no ELF installed (< EAPI 7)
    
    If no ELF files are installed, then we're obviously
    not going to have a NEEDED file.
    
    The reason this didn't get hit sooner is because
    apparently very few of us are actually testing
    EAPI 6 actively - which figures.
    
    We only take this path for < EAPI 7 (non-dostrip)
    which means we're actually missing the estrip
    optimisation in bug #749624 for newer EAPIs!
    
    (Will be fixed in a followup).
    
    Bug: https://bugs.gentoo.org/749624
    Bug: https://bugs.gentoo.org/862606
    Fixes: bb88e766897f5e7e0b0a10c48cf99a04edb73a40
    Signed-off-by: Sam James <sam@gentoo.org>

 bin/estrip | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2022-08-23 00:39:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=328977ffff1aa2d13cd3d8f7b5cb01eea6d634f5

commit 328977ffff1aa2d13cd3d8f7b5cb01eea6d634f5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-08-23 00:38:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-23 00:39:03 +0000

    sys-apps/portage: add 3.0.35
    
    Closes: https://bugs.gentoo.org/859439
    Closes: https://bugs.gentoo.org/672916
    Closes: https://bugs.gentoo.org/858791
    Closes: https://bugs.gentoo.org/862600
    Closes: https://bugs.gentoo.org/862606
    Closes: https://bugs.gentoo.org/863422
    Closes: https://bugs.gentoo.org/864382
    Closes: https://bugs.gentoo.org/865635
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.35.ebuild | 273 +++++++++++++++++++++++++++++++++
 2 files changed, 274 insertions(+)