https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sci-astronomy/stellarium-0.22.2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 795733 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) FAILED: src/stellarium /var/tmp/portage/sci-astronomy/stellarium-0.22.2/work/stellarium-0.22.2_build/src/stelMain_autogen/DMHXEJ42XS/../../../../stellarium-0.22.2/src/gui/StelDialog.hpp:230:7: error: virtual table of type ‘struct CustomProxy’ violates one definition rule [-Werror=odr]
The build PR is merged upstream, but the tests fail: https://github.com/Stellarium/stellarium/issues/2591
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28410219672502497f887670ae4fc9eda6cd13ff commit 28410219672502497f887670ae4fc9eda6cd13ff Author: Alexey Sokolov <alexey+gentoo@asokolov.org> AuthorDate: 2022-11-04 23:11:05 +0000 Commit: Jason Zaman <perfinion@gentoo.org> CommitDate: 2022-11-05 01:32:24 +0000 sci-astronomy/stellarium: add 1.1 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org> Closes: https://bugs.gentoo.org/862249 Bug: https://bugs.gentoo.org/745234 Signed-off-by: Jason Zaman <perfinion@gentoo.org> sci-astronomy/stellarium/Manifest | 3 + .../stellarium/files/stellarium-1.1-qxlsx.patch | 11 ++ sci-astronomy/stellarium/metadata.xml | 3 + sci-astronomy/stellarium/stellarium-1.1.ebuild | 172 +++++++++++++++++++++ 4 files changed, 189 insertions(+)
