https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-libs/xdp-tools-1.2.3 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 795089 [details] build.log build log and emerge --info
See also: https://github.com/xdp-project/xdp-tools/issues/137
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80fffaf8a1d422cbbb5d0984bc693128f8256a49 commit 80fffaf8a1d422cbbb5d0984bc693128f8256a49 Author: Holger Hoffstätte <holger@applied-asynchrony.com> AuthorDate: 2023-03-08 22:12:29 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-03-10 12:06:23 +0000 net-libs/xdp-tools: various build improvements - disable LTO - remove -Werror from Makefiles - fix xdpdump build error with clang - add hint about mounting bpffs Bug: https://bugs.gentoo.org/861587 Bug: https://bugs.gentoo.org/880919 Bug: https://bugs.gentoo.org/899744 Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com> Closes: https://github.com/gentoo/gentoo/pull/30005 Signed-off-by: Sam James <sam@gentoo.org> net-libs/xdp-tools/files/1.3.1-no-Werror.patch | 97 ++++++++++++++++++++++ net-libs/xdp-tools/files/1.3.1-xdpdump-clang.patch | 36 ++++++++ ...s-1.3.1-r1.ebuild => xdp-tools-1.3.1-r2.ebuild} | 25 ++++++ 3 files changed, 158 insertions(+)
