Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861461 - net-irc/ninja-1.5.9_pre14-r2 fails to compile (lto): ninja.c:327:15: error: type of [-Werror=lto-type-mismatch]
Summary: net-irc/ninja-1.5.9_pre14-r2 fails to compile (lto): ninja.c:327:15: error: t...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-27 12:30 UTC by Agostino Sarubbo
Modified: 2024-05-08 20:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,97.25 KB, text/plain)
2022-07-27 12:30 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-27 12:30:22 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-irc/ninja-1.5.9_pre14-r2 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-27 12:30:24 UTC
Created attachment 794951 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-12 03:59:27 UTC
long-dead upstream, doesn't build w/ modern c (configure), autoreconf fails w/ autoconf-2.72, ...
Comment 3 Eli Schwartz 2024-05-08 01:57:20 UTC
For context, trying to eautoreconf successfully produces a script that then does this:

checking for hpux version... no
checking for ultrix... no
checking for sequent/ptx... ./configure: 4401: Syntax error: "}" unexpected (expecting "fi")


configure.in is... not worth fixing. ;)
Comment 4 Larry the Git Cow gentoo-dev 2024-05-08 19:21:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02752fdc603d04f173f3e3afc76436c8f8f60b88

commit 02752fdc603d04f173f3e3afc76436c8f8f60b88
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-05-08 02:01:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-08 19:19:29 +0000

    package.mask: Last rite net-irc/ninja
    
    Bug: https://bugs.gentoo.org/731180
    Bug: https://bugs.gentoo.org/861461
    Bug: https://bugs.gentoo.org/888577
    Bug: https://bugs.gentoo.org/889930
    Bug: https://bugs.gentoo.org/900084
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)