Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 861263 - net-analyzer/thcrut-1.2.5-r2 fails to compile (lto): network_raw.h:8:35: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
Summary: net-analyzer/thcrut-1.2.5-r2 fails to compile (lto): network_raw.h:8:35: erro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on: 881677
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-26 15:16 UTC by Agostino Sarubbo
Modified: 2022-12-20 14:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,65.97 KB, text/plain)
2022-07-26 15:16 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-26 15:16:02 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-analyzer/thcrut-1.2.5-r2 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-26 15:16:04 UTC
Created attachment 794609 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 15:16:06 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


./configure: line 7265: ./pcre-3.9/pcre-config: No such file or directory
./configure: line 7265: libnet-config: command not found
./configure: line 7266: ./pcre-3.9/pcre-config: No such file or directory
./configure: line 7266: libnet-config: command not found
network_raw.h:8:35: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wstrict-aliasing]]
Comment 3 Larry the Git Cow gentoo-dev 2022-12-20 14:26:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02ab4e02e3d0380754f7cc7441d7737adb25680e

commit 02ab4e02e3d0380754f7cc7441d7737adb25680e
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2022-12-20 13:55:53 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-12-20 14:25:29 +0000

    net-analyzer/thcrut: treeclean
    
    Closes: https://bugs.gentoo.org/731154
    Closes: https://bugs.gentoo.org/861263
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 net-analyzer/thcrut/Manifest                       |  1 -
 .../thcrut/files/thcrut-1.2.5-configure.patch      | 42 --------------
 net-analyzer/thcrut/files/thcrut-1.2.5-flags.patch | 11 ----
 .../thcrut/files/thcrut-1.2.5-fno-common.patch     | 20 -------
 .../thcrut/files/thcrut-1.2.5-libnet.patch         | 65 ----------------------
 net-analyzer/thcrut/metadata.xml                   | 11 ----
 net-analyzer/thcrut/thcrut-1.2.5-r2.ebuild         | 35 ------------
 profiles/package.mask                              |  1 -
 8 files changed, 186 deletions(-)