https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-tv/kodi-19.4-r2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 794273 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) FAILED: kodi-x11 fatal: not a git repository (or any parent up to mount point /var/tmp) /var/tmp/portage/media-tv/kodi-19.4-r2/work/xbmc-19.4-Matrix/xbmc/playlists/SmartPlayList.cpp:46: error: type ‘struct translateField’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
lto_tinderbox has reproduced this issue with version 19.4-r4 - Updating summary.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f454c9a9c209a829a4066c71aad5845e58ce720 commit 8f454c9a9c209a829a4066c71aad5845e58ce720 Author: Alfred Wingate <parona@protonmail.com> AuthorDate: 2023-12-24 14:09:33 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-21 04:41:08 +0000 media-tv/kodi: add 20.3 * Drop riscv due to new dependency sci-libs/kissfft. Bug: https://bugs.gentoo.org/779184 Bug: https://bugs.gentoo.org/818262 Bug: https://bugs.gentoo.org/860984 Closes: https://bugs.gentoo.org/892547 Signed-off-by: Alfred Wingate <parona@protonmail.com> Signed-off-by: Sam James <sam@gentoo.org> media-tv/kodi/Manifest | 2 + media-tv/kodi/files/kodi-20.2-binutils-2.41.patch | 103 +++++ media-tv/kodi/kodi-20.3.ebuild | 474 ++++++++++++++++++++++ 3 files changed, 579 insertions(+)
As noted above -- fixed in kodi 20
