Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 860441 - media-sound/audacity-2.4.2-r3 fails to compile (lto): security.c:89: error: type of getcwd does not match original declaration [-Werror=lto-type-mismatch]
Summary: media-sound/audacity-2.4.2-r3 fails to compile (lto): security.c:89: error: t...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
Keywords: PATCH
Depends on:
Blocks: lto clang-16-porting
  Show dependency tree
Reported: 2022-07-24 07:53 UTC by Agostino Sarubbo
Modified: 2022-10-14 01:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

build.log.xz (build.log.xz,36.16 KB, application/x-xz)
2022-07-24 07:53 UTC, Agostino Sarubbo
audacity-2.4.2-implicit-decl.patch (audacity-2.4.2-implicit-decl.patch,260 bytes, patch)
2022-10-14 01:27 UTC, Alexander Miller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-24 07:53:12 UTC

Issue: media-sound/audacity-2.4.2-r2 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-24 07:53:15 UTC
Created attachment 793751 [details]

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-24 07:53:17 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:

FAILED: bin/Gentoo/audacity 
/var/tmp/portage/media-sound/audacity-2.4.2-r2/work/audacity-Audacity-2.4.2/lib-src/libnyquist/nyquist/xlisp/security.c:89: error: type of ‘getcwd’ does not match original declaration [-Werror=lto-type-mismatch]
Comment 3 Agostino Sarubbo gentoo-dev 2022-07-26 09:02:47 UTC
Here is a bit of explanation:

User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see

Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also:
Comment 4 Agostino Sarubbo gentoo-dev 2022-10-10 07:07:37 UTC
lto_tinderbox has reproduced this issue with version 2.4.2-r3 - Updating summary.
Comment 5 Alexander Miller 2022-10-14 01:27:48 UTC
Created attachment 824003 [details, diff]

This is not an LTO-only problem.
The package also fails with -Werror=implicit-function-declaration,
so it will be an issue with future clang releases (bug 870412).

See the following snippet from line 1204 of the build log:

/var/tmp/portage/media-sound/audacity-2.4.2-r2/work/audacity-Audacity-2.4.2/lib-src/libnyquist/nyquist/xlisp/security.c: In function ‘find_full_path’:
/var/tmp/portage/media-sound/audacity-2.4.2-r2/work/audacity-Audacity-2.4.2/lib-src/libnyquist/nyquist/xlisp/security.c:89:10: warning: implicit declaration of function ‘getcwd’; did you mean ‘getw’? [-Wimplicit-function-declaration]
   89 |     if (!getcwd(fullname, STRMAX)) {
      |          ^~~~~~
      |          getw

The attached patch fixes the issue by adding the missing #include statement.
(They didn't forget to include unistd.h, but the header with platform-specific
definitions, specifically UNIX, that controls the inclusion of the former.)