Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 859577 - dev-util/maturin-0.13.0 - fails to run testsuite on ppc/ppc64
Summary: dev-util/maturin-0.13.0 - fails to run testsuite on ppc/ppc64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC64 Linux
: Normal normal (vote)
Assignee: Ionen Wolkens
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2022-07-20 20:33 UTC by ernsteiswuerfel
Modified: 2022-07-28 12:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (ppc64, 0.13.0) (maturin-0.13.0:20220720-172905.log,284.42 KB, text/plain)
2022-07-20 20:33 UTC, ernsteiswuerfel
Details
emerge --info (file_859577.txt,6.56 KB, text/plain)
2022-07-20 20:34 UTC, ernsteiswuerfel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2022-07-20 20:33:03 UTC
Created attachment 792635 [details]
build.log (ppc64, 0.13.0)

[...]
     Running `/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/build/winapi-1046be2ee50c18c9/build-script-build`
     Running `rustc --crate-name winapi /var/tmp/portage/dev-util/maturin-0.13.0/work/cargo_home/gentoo/winapi-0.3.9/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="consoleapi"' --cfg 'feature="errhandlingapi"' --cfg 'feature="fileapi"' --cfg 'feature="handleapi"' --cfg 'feature="knownfolders"' --cfg 'feature="libloaderapi"' --cfg 'feature="minwinbase"' --cfg 'feature="minwindef"' --cfg 'feature="ntsecapi"' --cfg 'feature="objbase"' --cfg 'feature="processenv"' --cfg 'feature="processthreadsapi"' --cfg 'feature="shlobj"' --cfg 'feature="std"' --cfg 'feature="sysinfoapi"' --cfg 'feature="winbase"' --cfg 'feature="wincon"' --cfg 'feature="winerror"' --cfg 'feature="winnt"' --cfg 'feature="winsock2"' --cfg 'feature="winuser"' --cfg 'feature="winver"' --cfg 'feature="wtypesbase"' -C metadata=06fd09eedd2d4fce -C extra-filename=-06fd09eedd2d4fce --out-dir /var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/deps -L dependency=/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/deps --cap-lints allow -C target-cpu=970`
   Compiling platform-info v0.2.0
     Running `rustc --crate-name platform_info --edition=2018 /var/tmp/portage/dev-util/maturin-0.13.0/work/cargo_home/gentoo/platform-info-0.2.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C metadata=bcfcdd212ddc3bc7 -C extra-filename=-bcfcdd212ddc3bc7 --out-dir /var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/deps -L dependency=/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/deps --extern libc=/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/deps/liblibc-63ea3e21bb9a0378.rmeta --extern winapi=/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/deps/libwinapi-06fd09eedd2d4fce.rmeta --cap-lints allow -C target-cpu=970`
     Running `/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/build/ring-96500a72928f8f6b/build-script-build`
error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `/var/tmp/portage/dev-util/maturin-0.13.0/work/maturin-0.13.0/target/release/build/ring-96500a72928f8f6b/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /var/tmp/portage/dev-util/maturin-0.13.0/work/cargo_home/gentoo/ring-0.16.20/build.rs:358:10
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed
 * ERROR: dev-util/maturin-0.13.0::gentoo failed (test phase):
 *   cargo test failed
Comment 1 ernsteiswuerfel archtester 2022-07-20 20:34:01 UTC
Created attachment 792638 [details]
emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-20 20:38:44 UTC
Ring is completely broken on ppc64 because upstream won't reply to the PR from IBM to add it. Bleh.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-20 20:39:29 UTC
(In reply to Sam James from comment #2)
> Ring is completely broken on ppc64 because upstream won't reply to the PR
> from IBM to add it. Bleh.

(same issue with s390x too.)
Comment 4 Ionen Wolkens gentoo-dev 2022-07-20 23:13:58 UTC
fwiw I tried patching, but the PR only applies to current snapshot (not ring-0.16.20, and building against it require changes to other crates (not compatible as far as I can see, and don't think I want to try backporting the PR).

Maybe the older PR would work but my understanding is that it wasn't quite ready.

If anyone want to play with this, just need something like (assuming ${WORKDIR}/ring):

printf '[patch.crates-io]\nring = { path = "../ring" }' >> Cargo.toml || die

Add ring's new crates to CRATES if any, and remove ring-0.16.20. If it's a snapshot, may need to spoof the version in ../ring/Cargo.toml to 0.16.20/0_16_20 for simplicity.

tl;dr I don't think I can do anything about this at this time
Comment 5 Ionen Wolkens gentoo-dev 2022-07-20 23:18:34 UTC
If it can build e.g. dev-python/watchfiles, going forward with keywording would still wfm disregarding tests.

maturin upstream technically supports s390x and ppc64le (they have binaries)
Comment 6 Ionen Wolkens gentoo-dev 2022-07-20 23:44:48 UTC
Hm, actually maybe I can improve this, this is just about disabling the rustls feature.
Comment 7 Larry the Git Cow gentoo-dev 2022-07-21 00:14:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1116a3506008948831a89beee42095efc0a0bd61

commit 1116a3506008948831a89beee42095efc0a0bd61
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-07-21 00:11:26 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-07-21 00:14:18 +0000

    dev-util/maturin: disable rustls on arches where ring is broken
    
    Upstream already disables for some but this doesn't
    carry over to tests.
    
    Bug: https://bugs.gentoo.org/859577
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 dev-util/maturin/maturin-0.13.0.ebuild | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Comment 8 Ionen Wolkens gentoo-dev 2022-07-21 00:15:16 UTC
Untested on affected arches, but looking at the build.log I don't see ring- being built anywhere with this.

Feel free to close if it's fixed.
Comment 9 Ionen Wolkens gentoo-dev 2022-07-21 00:16:37 UTC
(feel free to add more arches if get this anywhere else)
Comment 10 Ionen Wolkens gentoo-dev 2022-07-27 15:21:32 UTC
wrt bug 859850 comment #4, can I get a new log for failing tests?

ring issues "should" be fixed, I had even poisoned the ring crate to be sure it wouldn't compile on amd64 and tests passed only if I added "use amd64" to the lot, so should be either a different failure or arguments weren't passed for some reason.
Comment 11 ernsteiswuerfel archtester 2022-07-27 16:20:36 UTC
(In reply to Ionen Wolkens from comment #10)
> wrt bug 859850 comment #4, can I get a new log for failing tests?
> 
> ring issues "should" be fixed, I had even poisoned the ring crate to be sure
> it wouldn't compile on amd64 and tests passed only if I added "use amd64" to
> the lot, so should be either a different failure or arguments weren't passed
> for some reason.

Had a closer look and it seems I was imprecise. I did a retest of 0.13.1. ppc64 passes tests now.

ppc now runs the testsuite but shows a few test failures. But as this is a different issue I'll close here and open a new bug for ppc test failures.
Comment 12 Larry the Git Cow gentoo-dev 2022-07-28 12:21:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4da0feb9792e14e7e6ce75a71945ed5ff5b32715

commit 4da0feb9792e14e7e6ce75a71945ed5ff5b32715
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2022-07-28 12:16:08 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-07-28 12:17:30 +0000

    dev-util/maturin: Disable rustls on riscv too in 0.13.1
    
    Bug: https://bugs.gentoo.org/859577
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 dev-util/maturin/maturin-0.13.1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)