Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 856106 - dev-lisp/roswell-21.10.14.111 fails to compile (lto): cmd-run.h:27:13: error: type of [-Werror=lto-type-mismatch]
Summary: dev-lisp/roswell-21.10.14.111 fails to compile (lto): cmd-run.h:27:13: error:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Danny
URL:
Whiteboard:
Keywords:
: 931083 (view as bug list)
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-07-03 07:39 UTC by Agostino Sarubbo
Modified: 2024-05-02 23:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,56.53 KB, text/plain)
2022-07-03 07:39 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-03 07:39:41 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lisp/roswell-21.10.14.111 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-03 07:39:43 UTC
Created attachment 789863 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:01:07 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Larry the Git Cow gentoo-dev 2024-05-02 04:32:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2343f3907d70a08674be77218f76ede6cb91f7ff

commit 2343f3907d70a08674be77218f76ede6cb91f7ff
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-05-02 04:21:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-02 04:31:31 +0000

    dev-lisp/roswell: mark as LTO-unsafe
    
    Listen, I definitely know it's LTO-unsafe.
    
    I can't actually get it to compile, but either way, it's definitely
    LTO-unsafe...
    
    The next compilation error is:
    
    ```
    /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: warning: resources.o: missing .note.GNU-stack section implies executable stack
    /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
    resources.o:(.rsrc$01+0x80): dangerous relocation: R_AMD64_IMAGEBASE with __ImageBase undefined
    resources.o:(.rsrc$01+0x90): dangerous relocation: R_AMD64_IMAGEBASE with __ImageBase undefined
    collect2: error: ld returned 1 exit status
    make[2]: *** [Makefile:436: ros] Error 1
    ```
    
    As you can tell from the linker error, it appears to be lisp code... if
    anyone can figure out why it happens you're welcome to it but I am not
    spending more time on lisp so this is me backing away now that the LTO
    bug can be closed. So long!
    
    Closes: https://bugs.gentoo.org/856106
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-lisp/roswell/roswell-20.05.14.106.ebuild | 13 +++++++++++--
 dev-lisp/roswell/roswell-21.10.14.111.ebuild | 13 +++++++++++--
 dev-lisp/roswell/roswell-22.12.14.113.ebuild | 11 ++++++++++-
 3 files changed, 32 insertions(+), 5 deletions(-)
Comment 4 Eli Schwartz 2024-05-02 23:27:55 UTC
*** Bug 931083 has been marked as a duplicate of this bug. ***