https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-libs/sink-0.8.0-r3 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 789851 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: common/libsink.so.0.8.0 fatal: not a git repository (or any parent up to mount point /var/tmp) /var/tmp/portage/dev-libs/sink-0.8.0-r3/work/sink-0.8.0/common/resourceaccess.cpp:61:8: error: type ‘struct QueuedCommand’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=601e9b1b4c436c61e9c3a91215274c8782fb2d11 commit 601e9b1b4c436c61e9c3a91215274c8782fb2d11 Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2023-10-11 19:06:47 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2023-10-11 19:07:01 +0000 dev-libs/sink & co: treeclean Closes: https://bugs.gentoo.org/907499 Closes: https://bugs.gentoo.org/904876 Closes: https://bugs.gentoo.org/872062 Closes: https://bugs.gentoo.org/856094 Signed-off-by: Florian Schmaus <flow@gentoo.org> dev-libs/kasync/Manifest | 1 - dev-libs/kasync/kasync-0.3.0.ebuild | 18 ------- dev-libs/kasync/metadata.xml | 11 ---- dev-libs/sink/Manifest | 1 - dev-libs/sink/files/sink-0.8.0-musl-execinfo.patch | 48 ----------------- dev-libs/sink/metadata.xml | 8 --- dev-libs/sink/sink-0.8.0-r3.ebuild | 58 -------------------- mail-client/kube/Manifest | 1 - .../kube/files/kube-0.7.0-appdata-location.patch | 23 -------- .../kube/files/kube-0.7.0-require-cxx14.patch | 37 ------------- .../kube/files/kube-0.7.0-tests-optional.patch | 62 --------------------- mail-client/kube/kube-0.7.0-r1.ebuild | 63 ---------------------- mail-client/kube/metadata.xml | 8 --- net-libs/kdav2/Manifest | 1 - net-libs/kdav2/kdav2-0.3.0.ebuild | 38 ------------- net-libs/kdav2/metadata.xml | 8 --- net-libs/kimap2/Manifest | 1 - net-libs/kimap2/kimap2-0.3.0.ebuild | 27 ---------- net-libs/kimap2/metadata.xml | 8 --- profiles/package.mask | 10 ---- 20 files changed, 432 deletions(-)
