856058 – app-crypt/gcr >= 3.41 now requires gnome-keyring + libsecret make ssh-agent optional

Bug 856058 - app-crypt/gcr >= 3.41 now requires gnome-keyring + libsecret make ssh-agent optional

Summary: app-crypt/gcr >= 3.41 now requires gnome-keyring + libsecret make ssh-agent o...

Status:	RESOLVED NEEDINFO

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2022-07-03 03:43 UTC by Gino McCarty
Modified:	2022-10-19 03:12 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gino McCarty 2022-07-03 03:43:10 UTC

I have no idea why but it appears historically ssh-agent is forced to enable in all app-crypt/gcr ebuilds. This is a bit annoying for those who don't run gnome and are not interested in using gnome-keyring/libsecret framework.

Here is a patch to your ebuild to allow ssh agent to be optional


```
--- /usr/portage/app-crypt/gcr/gcr-3.41.0.ebuild	2022-07-02 17:53:08.987432450 -0700
+++ /usr/local/portage/app-crypt/gcr/gcr-3.41.0.ebuild	2022-07-02 20:33:26.143056059 -0700
@@ -12,7 +12,7 @@
 LICENSE="GPL-2+ LGPL-2+"
 SLOT="0/1" # subslot = suffix of libgcr-base-3 and co

-IUSE="gtk gtk-doc +introspection systemd test +vala"
+IUSE="gtk gtk-doc +introspection +ssh systemd test +vala"
 REQUIRED_USE="vala? ( introspection )"
 RESTRICT="!test? ( test )"

@@ -22,7 +22,7 @@
 	>=dev-libs/glib-2.44.0:2
 	>=dev-libs/libgcrypt-1.2.2:0=
 	>=app-crypt/p11-kit-0.19.0
-	>=app-crypt/libsecret-0.20
+	ssh? ( >=app-crypt/libsecret-0.20 )
 	systemd? ( sys-apps/systemd:= )
 	gtk? ( >=x11-libs/gtk+-3.22:3[introspection?] )
 	>=sys-apps/dbus-1
@@ -67,7 +67,7 @@
 		$(meson_use gtk)
 		$(meson_use gtk-doc gtk_doc)
 		-Dgpg_path="${EPREFIX}"/usr/bin/gpg
-		-Dssh_agent=true
+		-Dssh_agent=$(usex ssh true false)
 		$(meson_feature systemd)
 		$(meson_use vala vapi)
 	)
```


PS: this same behavior exists in gnome-base/gvfs , please pass through the meson options to not use gcr in gvfs.

Reproducible: Always

Comment 1 Matt Turner gentoo-dev

2022-07-03 23:12:06 UTC

> PS: this same behavior exists in gnome-base/gvfs , please pass through the meson options to not use gcr in gvfs.

Is gcr installed on your system only because of gnome-base/gvfs? What pulls in gvfs?

Comment 2 Gino McCarty 2022-07-03 23:32:20 UTC

Related Bug 856334

Comment 3 Matt Turner gentoo-dev

2022-07-10 18:53:36 UTC

(In reply to Matt Turner from comment #1)
> > PS: this same behavior exists in gnome-base/gvfs , please pass through the meson options to not use gcr in gvfs.
> 
> Is gcr installed on your system only because of gnome-base/gvfs? What pulls
> in gvfs?

Ping?

Comment 4 Matt Turner gentoo-dev

2022-10-19 03:12:46 UTC

(In reply to Matt Turner from comment #3)
> (In reply to Matt Turner from comment #1)
> > > PS: this same behavior exists in gnome-base/gvfs , please pass through the meson options to not use gcr in gvfs.
> > 
> > Is gcr installed on your system only because of gnome-base/gvfs? What pulls
> > in gvfs?
> 
> Ping?