https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-text/pspdftool-0.03 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 788606 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=efd1a1f09c5c37ee32ea6e1185a0d10305097ff6 commit efd1a1f09c5c37ee32ea6e1185a0d10305097ff6 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-02-29 22:29:27 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-29 23:57:39 +0000 app-text/pspdftool: mark LTO-unsafe, mark strict-aliasing unsafe The software is: - dead upstream since 2015 - maintainer-needed in gentoo - no reverse dependencies - unstable-only - a walking strict-aliasing problem It's not getting fixed any time soon, and there's nowhere to report its issues, so just filter out the most dangerous flags and pray nothing explodes. Closes: https://bugs.gentoo.org/855023 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> app-text/pspdftool/pspdftool-0.03.ebuild | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)