Bug 854900 – app-text/cuneiform-1.1.0-r3 fails to compile (lto): dif.c:68:16: error: type of lnhead_stick_get_incline does not match original declaration [-Werror=lto-type-mismatch]

• Status: RESOLVED PKGREMOVED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-06-28 18:21:22 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-text/cuneiform-1.1.0-r3 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

[Comment 1 Agostino Sarubbo 2022-06-28 18:21:24 UTC]

Created attachment 788531 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-06-28 18:21:26 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: cuneiform_src/Kern/dif/libdif32.so.1.1.0 
/var/tmp/portage/app-text/cuneiform-1.1.0-r3/work/cuneiform-linux-1.1.0/cuneiform_src/Kern/dif/src/dif.c:68:16: error: type of ‘lnhead_stick_get_incline’ does not match original declaration [-Werror=lto-type-mismatch]

[Comment 3 Agostino Sarubbo 2022-07-26 09:00:31 UTC]

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 4 Jan Psota 2024-08-31 00:04:04 UTC]

I compile using gcc with -fpermissive and USE=graphicsmagick
- works like magic!

[Comment 5 Larry the Git Cow 2024-09-23 03:49:33 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9247176b42c016df75946c2d10f9c32d48e57b5f

commit 9247176b42c016df75946c2d10f9c32d48e57b5f
Author:     Eli Schwartz <[e-mail]>
AuthorDate: 2024-09-23 03:38:12 +0000
Commit:     Eli Schwartz <[e-mail]>
CommitDate: 2024-09-23 03:49:01 +0000

    app-text/cuneiform: treeclean
    
    Closes: https://bugs.gentoo.org/937994 (pkgremoved)
    Closes: https://bugs.gentoo.org/914924 (pkgremoved)
    Closes: https://bugs.gentoo.org/931102 (pkgremoved)
    Closes: https://bugs.gentoo.org/882265 (pkgremoved)
    Closes: https://bugs.gentoo.org/880839 (pkgremoved)
    Closes: https://bugs.gentoo.org/863959 (pkgremoved)
    Closes: https://bugs.gentoo.org/854900 (pkgremoved)
    Closes: https://bugs.gentoo.org/829229 (pkgremoved)
    Signed-off-by: Eli Schwartz <[e-mail]>

 app-text/cuneiform/Manifest                        |   1 -
 app-text/cuneiform/cuneiform-1.1.0-r3.ebuild       |  61 -------
 .../cuneiform/files/cuneiform-1.1.0-c-assert.patch |  79 ---------
 .../cuneiform-1.1.0-fix_buffer_overflow.patch      |  24 ---
 .../cuneiform-1.1.0-fix_buffer_overflow_2.patch    |  15 --
 .../cuneiform/files/cuneiform-1.1.0-gcc11.patch    |  30 ----
 .../cuneiform/files/cuneiform-1.1.0-gcc6.patch     | 176 ---------------------
 .../cuneiform/files/cuneiform-1.1.0-gcc7.patch     |  97 ------------
 .../files/cuneiform-1.1.0-graphicsmagick.patch     |  40 -----
 .../cuneiform/files/cuneiform-1.1.0-libm.patch     |  22 ---
 .../cuneiform/files/cuneiform-1.1.0-typos.patch    |  53 -------
 app-text/cuneiform/files/cuneiform.1               | 166 -------------------
 app-text/cuneiform/metadata.xml                    |   8 -
 profiles/package.mask                              |   7 -
 14 files changed, 779 deletions(-)