https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-text/coolreader-3.2.59-r3 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 788525 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: cr3qt/cr3 /var/tmp/portage/app-text/coolreader-3.2.59-r3/work/coolreader-cr3.2.59/crengine/src/crtxtenc.cpp:1898:3: error: type ‘struct cp_stat_t’ violates the C++ One Definition Rule [-Werror=odr]
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8392c14d61f4cb4467b2d2e4b02218fce56e6a40 commit 8392c14d61f4cb4467b2d2e4b02218fce56e6a40 Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2023-11-14 10:19:51 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2023-11-14 10:20:11 +0000 app-text/coolreader: treeclean Closes: https://bugs.gentoo.org/915634 Closes: https://bugs.gentoo.org/913470 Closes: https://bugs.gentoo.org/854894 Closes: https://bugs.gentoo.org/632678 Signed-off-by: Florian Schmaus <flow@gentoo.org> app-text/coolreader/Manifest | 1 - app-text/coolreader/coolreader-3.2.59-r4.ebuild | 71 -------------- .../coolreader/files/coolreader-wxwidgets.patch | 109 --------------------- app-text/coolreader/metadata.xml | 17 ---- profiles/package.mask | 7 -- 5 files changed, 205 deletions(-)
