https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-portage/ufed-0.96 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 788492 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Assigning to proj/ufed.git's primary committer. Here's the failing compile command: x86_64-pc-linux-gnu-gcc -march=native -fstack-protector-all -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-clash-protection -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Wformat -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Werror=int-conversion -Werror=incompatible-pointer-types -Wall -Wextra -Wmissing-prototypes -Wstrict-prototypes -pedantic -Wl,-O1 -Wl,--as-needed -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Wl,--defsym=__gentoo_check_ldflags__=0 -o ufed-curses ufed-curses.o ufed-curses-checklist.o ufed-curses-help.o ufed-curses-globals.o ufed-curses-types.o -lncursesw -ltinfow /var/tmp/portage/app-portage/ufed-0.96/work/ufed-0.96/ufed-curses-globals.h:24:19: error: type of ‘ro_mode’ does not match original declaration [-Werror=lto-type-mismatch] 24 | extern bool ro_mode; | ^ /var/tmp/portage/app-portage/ufed-0.96/work/ufed-0.96/ufed-curses-globals.c:13:12: note: type ‘int’ should match type ‘_Bool’ 13 | int ro_mode = false; | ^ /var/tmp/portage/app-portage/ufed-0.96/work/ufed-0.96/ufed-curses-globals.c:13:12: note: ‘ro_mode’ was previously declared here /var/tmp/portage/app-portage/ufed-0.96/work/ufed-0.96/ufed-curses-globals.c:13:12: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used lto1: some warnings being treated as errors lto-wrapper: fatal error: x86_64-pc-linux-gnu-gcc returned 1 exit status compilation terminated. /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed collect2: error: ld returned 1 exit status
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed609b72aee1087c292010ed35d121239ba9164a commit ed609b72aee1087c292010ed35d121239ba9164a Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-07 00:21:12 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-07 11:46:24 +0000 app-portage/ufed: mark as LTO-unsafe Bug: https://bugs.gentoo.org/854864 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> app-portage/ufed/ufed-0.96.ebuild | 12 ++++++++++-- app-portage/ufed/ufed-9999.ebuild | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-)
