Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 854597 - app-i18n/nabi-1.0.0 fails to compile (lto): handler.c:142:14: error: type of [-Werror=lto-type-mismatch]
Summary: app-i18n/nabi-1.0.0 fails to compile (lto): handler.c:142:14: error: type of ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-06-27 15:20 UTC by Agostino Sarubbo
Modified: 2024-03-06 22:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,98.35 KB, text/plain)
2022-06-27 15:20 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-06-27 15:20:36 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-i18n/nabi-1.0.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Comment 1 Agostino Sarubbo gentoo-dev 2022-06-27 15:20:38 UTC
Created attachment 788048 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-07-26 09:00:20 UTC
Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-28 11:02:52 UTC
https://github.com/libhangul/nabi/commit/11f55b4de0db41faff21f35f22b4ff17a52ef741 fixes some of the warnings but not the mismatch.
Comment 4 Larry the Git Cow gentoo-dev 2022-11-23 08:28:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ddab4e54c7c46466f951d49e25101187001a1dd4

commit ddab4e54c7c46466f951d49e25101187001a1dd4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-11-23 08:04:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-23 08:28:40 +0000

    app-i18n/nabi: add 1.0.1
    
    Closes: https://bugs.gentoo.org/875716
    Bug: https://bugs.gentoo.org/854597
    Signed-off-by: Sam James <sam@gentoo.org>

 app-i18n/nabi/Manifest          |  1 +
 app-i18n/nabi/nabi-1.0.1.ebuild | 62 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
Comment 5 Eli Schwartz 2024-03-06 22:23:57 UTC
Far as I can tell, it did fix it. No -Werror=lto-type-mismatch anymore, anyway.