Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 853118 - app-office/abiword-3.0.5 - xap_Dialog.cpp:270:24: error: cast from 'std::nullptr_t' to 'char' loses precision [-fpermissive] (on musl)
Summary: app-office/abiword-3.0.5 - xap_Dialog.cpp:270:24: error: cast from 'std::null...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: musl-porting 839975
  Show dependency tree
 
Reported: 2022-06-19 19:26 UTC by ernsteiswuerfel
Modified: 2022-09-14 22:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (abiword-3.0.5:20220619-182049.log,479.13 KB, text/plain)
2022-06-19 19:26 UTC, ernsteiswuerfel
Details
emerge --info (file_853118.txt,6.98 KB, text/plain)
2022-06-19 19:26 UTC, ernsteiswuerfel
Details
musl-1.2.3.patch (musl-1.2.3.patch,1.03 KB, patch)
2022-06-20 14:34 UTC, ernsteiswuerfel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2022-06-19 19:26:07 UTC
Created attachment 786341 [details]
build.log

[...]
libtool: compile:  x86_64-gentoo-linux-musl-g++ -std=c++11 -DHAVE_CONFIG_H -I. -I../../../.. -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/libffi/include -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/wv -I/usr/include/enchant-2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libgoffice-0.10 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/librsvg-2.0 -I/usr/include/gtk-3.0/unix-print -pthread -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_0 -I/usr/include -I../../../.. -I../../../../src/af/ev/gtk -I../../../../src/af/ev/xp -I../../../../src/af/gr/gtk -I../../../../src/af/gr/xp -I../../../../src/af/util/unix -I../../../../src/af/util/xp -I../../../../src/af/xap/gtk -I../../../../src/af/xap/xp -Wall -Wextra -Wsign-compare -Wpointer-arith -Wchar-subscripts -Wwrite-strings -Wmissing-noreturn -Wformat-overflow=2 -Wunused -Wpointer-arith -Wshadow -Os -march=bdver3 -mtune=bdver3 -pipe -Wno-overloaded-virtual -c xap_Dialog.cpp  -fPIC -DPIC -o .libs/xap_Dialog.o
xap_Dialog.cpp: In member function 'void XAP_Dialog_Modeless::BuildWindowName(char*, const char*, UT_uint32) const':
xap_Dialog.cpp:270:24: error: cast from 'std::nullptr_t' to 'char' loses precision [-fpermissive]
  270 |         *pWindowName = (char) NULL;
      |                        ^
make[5]: *** [Makefile:885: xap_Dialog.lo] Error 1
make[5]: Leaving directory '/var/tmp/portage/app-office/abiword-3.0.5/work/abiword-3.0.5/src/af/xap/xp'
make[4]: *** [Makefile:542: all-recursive] Error 1
Comment 1 ernsteiswuerfel archtester 2022-06-19 19:26:43 UTC
Created attachment 786344 [details]
emerge --info
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-20 05:24:00 UTC
(In reply to Sam James from comment #2)
> https://git.alpinelinux.org/aports/commit/
> ?id=d0ecd5e124d8a4504f9e72414a9b3e077682a883

(prob. https://gitlab.gnome.org/World/AbiWord/-/commit/857cd86def49fe8557cfe123830c4d5a61eee732)
Comment 4 ernsteiswuerfel archtester 2022-06-20 14:34:38 UTC
Created attachment 786479 [details, diff]
musl-1.2.3.patch

(In reply to Sam James from comment #3)
> (prob.
> https://gitlab.gnome.org/World/AbiWord/-/commit/
> 857cd86def49fe8557cfe123830c4d5a61eee732)
Thanks for the hint!

Luckily only a small portion of this big patch is necessary to make abiword-3.0.5 build and run. I'll attach it.
Comment 5 Larry the Git Cow gentoo-dev 2022-09-14 22:33:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4446f9b14a8208c2a826d5b6920490dd13165403

commit 4446f9b14a8208c2a826d5b6920490dd13165403
Author:     brahmajit das <listout@protonmail.com>
AuthorDate: 2022-09-13 19:11:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-14 22:28:48 +0000

    app-office/abiword: Fix lose precision on musl
    
    abiword fails on musl with loses precision error for code `*pWindowName
    = (char) NULL`. This patch fixes it. Patch is taken from Gentoo dev
    ernsteiswuerfel [1], also refer [2]
    
    [1]: https://853118.bugs.gentoo.org/attachment.cgi?id=786479
    [2]: https://gitlab.gnome.org/World/AbiWord/-/commit/857cd86def49fe8557cfe123830c4d5a61eee732
    
    Closes: https://bugs.gentoo.org/853118
    Signed-off-by: brahmajit das <listout@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/26467
    Signed-off-by: Sam James <sam@gentoo.org>

 app-office/abiword/abiword-3.0.5.ebuild            |  1 +
 .../abiword-3.0.5-musl-lose-precision-fix.patch    | 37 ++++++++++++++++++++++
 2 files changed, 38 insertions(+)