Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 846158 - net-misc/omniORB: needs upgrade to Python 3.10 (PythonCompatUpdate)
Summary: net-misc/omniORB: needs upgrade to Python 3.10 (PythonCompatUpdate)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: py310, python3.10-compat
  Show dependency tree
 
Reported: 2022-05-18 19:03 UTC by Sam James
Modified: 2022-06-14 16:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
omniORB 4.3.0 ebuild (omniORB-4.3.0.ebuild,2.29 KB, text/plain)
2022-06-10 08:49 UTC, Thomas Juerges
Details
Patch per instructions (0001-net-misc-omniORB-add-4.3.0.patch,4.52 KB, patch)
2022-06-10 16:37 UTC, Thomas Juerges
Details | Diff
Patch per instructions (0001-net-misc-omniORB-add-4.3.0.patch,4.49 KB, text/plain)
2022-06-10 16:47 UTC, Thomas Juerges
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-18 19:03:03 UTC
This package does not support Python 3.10. Please test it with Python 3.10 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://archives.gentoo.org/gentoo-dev/message/13aa993921f19b6b095297721ffb0d0b. Ask in #gentoo-python on IRC if need any help.

$ pkgcheck scan -k PythonCompatUpdate net-misc/omniORB
net-misc/omniORB
  PythonCompatUpdate: version 4.2.4: PYTHON_COMPAT updates available: python3_10, python3_11
Comment 1 Larry the Git Cow gentoo-dev 2022-05-22 03:13:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=069bf27fe1dc6f1704b4c7b5c9c5c684e602316d

commit 069bf27fe1dc6f1704b4c7b5c9c5c684e602316d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-22 02:57:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-22 02:57:43 +0000

    profiles: last-rite net-misc/omniORB
    
    Bug: https://bugs.gentoo.org/731674
    Bug: https://bugs.gentoo.org/846158
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Thomas Juerges 2022-06-10 08:49:27 UTC
Created attachment 783833 [details]
omniORB 4.3.0 ebuild

Hi all,

omniORB's stable version 4.3.0 was released on 2022-01-09. Seeing that omniORB is tagged for removal, I have created an ebuild for the latest stable omniORB version. It supports Python 3.10 and I have added the ~arm64 arch.

I have tested the built omniORB 4.3.0 in a real world installation and it works well together with omniORB 4.2.4 on other hosts in the network.

I hope that this helps to continue supporting omniORB on Gentoo.

Cheers,
Thomas
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-10 08:51:11 UTC
(In reply to Thomas Juerges from comment #2)
> Created attachment 783833 [details]
> omniORB 4.3.0 ebuild
> 
> Hi all,
> 
> omniORB's stable version 4.3.0 was released on 2022-01-09. Seeing that
> omniORB is tagged for removal, I have created an ebuild for the latest
> stable omniORB version. It supports Python 3.10 and I have added the ~arm64
> arch.
> 
> I have tested the built omniORB 4.3.0 in a real world installation and it
> works well together with omniORB 4.2.4 on other hosts in the network.
> 
> I hope that this helps to continue supporting omniORB on Gentoo.
> 
> Cheers,
> Thomas

Thanks!

Would you be willing to continue maintaining it? I can assist with the procedure side of thihngs.

It consists of you being listed in metadata.xml, handling bugs, and adding new versions when they come out. Submisions are usually done via github PRs but attaching patches here (from git format-patch) works too.
Comment 4 Thomas Juerges 2022-06-10 08:56:03 UTC
Sigh. I feared that this would be the end-result. :-)

Yes, I am happy to try. Please be advised that I have never chaperoned a Gentoo package and that I have actually no clue what I will be getting into. :-)

But I can promise that I will do my best.

Cheers,
Thomas
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-10 09:04:29 UTC
(In reply to Thomas Juerges from comment #4)
> Sigh. I feared that this would be the end-result. :-)
> 
> Yes, I am happy to try. Please be advised that I have never chaperoned a
> Gentoo package and that I have actually no clue what I will be getting into.
> :-)
> 
> But I can promise that I will do my best.
> 
> Cheers,
> Thomas

That's more than good enough for me!

Could you:
1. emerge -av pkgdev dev-vcs/git
2. git clone https://github.com/gentoo/gentoo (or https://anongit.gentoo.org/git/repo/gentoo.git);
3. cd gentoo/net-misc/omniORB
4. Update metadata.xml to become maintainer (example: https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Proxied_maintainer_in_metadata.xml)
5. Add the new ebuild in the directory, 'git add foo.ebuild', then 'pkgdev commit -c 846158' to close this bug
6. Run "git format-patch HEAD~1" and upload the patch file here.

But if you really don't want to do this, that's okay. I can unmask it and bump this with your ebuild here, but there's a chance we're going to end up in this situation again, or someone bumps it because it's out of date, but that person doesn't use it :(
Comment 6 Thomas Juerges 2022-06-10 09:17:50 UTC
OK, Sam, I'll do it. Let's see if I can be of any help.

I'll get to it later today.

Cheers,
Thomas
Comment 7 Thomas Juerges 2022-06-10 16:37:49 UTC
Created attachment 783929 [details, diff]
Patch per instructions
Comment 8 Thomas Juerges 2022-06-10 16:40:38 UTC
Sorry, I got the e-mail address in the signed-off message wrong. I'll upload a new patch.
Comment 9 Thomas Juerges 2022-06-10 16:47:31 UTC
Created attachment 783932 [details]
Patch per instructions
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-14 14:42:45 UTC
(In reply to Thomas Juerges from comment #9)
> Created attachment 783932 [details]
> Patch per instructions

Nice!

Some notes:
- The paths seemed slightly mangled but not sure what happened there, was easy enough to fix. Did you maybe run 'git format-patch ...' from within a subdirectory or something? Not sure. I usually run 'git format-patch origin/master' or similar and then it just works. It might act odd if you give it a path, but should work...

- Re keywords: when bumping, do ekeyword \~all new-version.ebuild. This resets it to "~arch" or "testing" (https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades).

- Re keywords: I noticed ~arm64 appeared. Did you test on arm64 or was it accidental? Normally we file keywording bugs to let an arch team test it, but if you really used it, I can keep it in. I'll drop it for now just in case it was a mistake, but no problem to restore it.

I've sorted that and also dropped Python 3.7 as the support for it is long gone (does nothing).

Thanks a bunch!
Comment 11 Larry the Git Cow gentoo-dev 2022-06-14 14:47:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65161376f2f02556fa4f72e5fbaf491116de81c6

commit 65161376f2f02556fa4f72e5fbaf491116de81c6
Author:     Thomas Juerges <aliens.satin0y@icloud.com>
AuthorDate: 2022-06-10 16:45:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-14 14:39:36 +0000

    net-misc/omniORB: add 4.3.0
    
    Closes: https://bugs.gentoo.org/846158
    Signed-off-by: Thomas Juerges <aliens.satin0y@icloud.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/omniORB/Manifest             |  1 +
 net-misc/omniORB/metadata.xml         |  5 +-
 net-misc/omniORB/omniORB-4.3.0.ebuild | 92 +++++++++++++++++++++++++++++++++++
 3 files changed, 97 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10b4be1473698fe7f4cd3e04cd578e273101d63e

commit 10b4be1473698fe7f4cd3e04cd578e273101d63e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-14 14:43:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-14 14:44:11 +0000

    net-misc/omniORB: small fixups
    
    - Drop ~arm64 for now until clarification received
    - Add proxy-maint to metadata.xml
    - Drop back to ~arch
    - Drop no-op Python 3.7
    
    Bug: https://bugs.gentoo.org/846158
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/omniORB/metadata.xml         | 10 +++++++---
 net-misc/omniORB/omniORB-4.3.0.ebuild |  6 +++---
 2 files changed, 10 insertions(+), 6 deletions(-)
Comment 12 Larry the Git Cow gentoo-dev 2022-06-14 15:00:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff66b2e87e3f83ae9f57ba8dec155b49c40d38d7

commit ff66b2e87e3f83ae9f57ba8dec155b49c40d38d7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-14 15:00:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-14 15:00:30 +0000

    profiles: drop last-rites for net-misc/omniORB
    
    Bug: https://bugs.gentoo.org/731674
    Bug: https://bugs.gentoo.org/846158
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/package.mask | 5 -----
 1 file changed, 5 deletions(-)
Comment 13 Thomas Juerges 2022-06-14 16:08:11 UTC
(In reply to Sam James from comment #10)
> (In reply to Thomas Juerges from comment #9)
> > Created attachment 783932 [details]
> > Patch per instructions
> 
> Nice!
> 
> Some notes:
> - The paths seemed slightly mangled but not sure what happened there, was
> easy enough to fix. Did you maybe run 'git format-patch ...' from within a
> subdirectory or something? Not sure. I usually run 'git format-patch
> origin/master' or similar and then it just works. It might act odd if you
> give it a path, but should work...

Yeah, I believe I was in the omniORB directory. Sorry for that. This is very useful advice!


> - Re keywords: when bumping, do ekeyword \~all new-version.ebuild. This
> resets it to "~arch" or "testing"
> (https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades).

Erm. Yes. Guilty as charged. I understand now that my laissez-faire approach to keyword omniORB for ~arm64 was a bit too relaxed. :-) Will use the proper tooling  next time.


> - Re keywords: I noticed ~arm64 appeared. Did you test on arm64 or was it
> accidental? Normally we file keywording bugs to let an arch team test it,
> but if you really used it, I can keep it in. I'll drop it for now just in
> case it was a mistake, but no problem to restore it.

I tested it only on arm64 as I have for Gentoo only arm64 hardware available. Everything else is macOS.


> I've sorted that and also dropped Python 3.7 as the support for it is long
> gone (does nothing).
> 
> Thanks a bunch!

Thanks for sorting this all! And cheers for the pointers. I will try to do better next time. :-)