Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 843716 - qmail.eclass uses reserved function names
Summary: qmail.eclass uses reserved function names
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Lowest QA (vote)
Assignee: Rolf Eike Beer
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 843680
  Show dependency tree
 
Reported: 2022-05-11 06:55 UTC by Ulrich Müller
Modified: 2022-05-21 17:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2022-05-11 06:55:06 UTC
Function names qmail_*_install_hook are reserved names and must not be used.

Policy reference:
https://projects.gentoo.org/pms/8/pms.html#x1-13700012.3.17
Comment 1 Ulrich Müller gentoo-dev 2022-05-16 10:20:45 UTC
What is the purpose of these hook functions anyway? They aren't documented as eclass functions, and no ebuild in the tree seems to make use of them.
Comment 3 Larry the Git Cow gentoo-dev 2022-05-21 17:00:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d6432a583b9a2c858cccb05b9caf58d93553ba3

commit 3d6432a583b9a2c858cccb05b9caf58d93553ba3
Author:     Rolf Eike Beer <eike@sf-mail.de>
AuthorDate: 2022-05-16 14:43:56 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-05-21 17:00:01 +0000

    qmail.eclass: drop obsolete install hooks
    
    The last user went away with mail-mta/qmail-ldap.
    
    Closes: https://bugs.gentoo.org/843716
    Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eclass/qmail.eclass | 24 ------------------------
 1 file changed, 24 deletions(-)