Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 84228 - sysfsutils: libsysfs write_attribute bug if attribute is empty
Summary: sysfsutils: libsysfs write_attribute bug if attribute is empty
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Greg Kroah-Hartman (RETIRED)
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 84234
  Show dependency tree
 
Reported: 2005-03-05 13:41 UTC by Dominik Brodowski
Modified: 2005-05-20 05:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch for libsysfs-1.2.0 (libsysfs-write-attribute.patch,998 bytes, patch)
2005-03-05 13:42 UTC, Dominik Brodowski 		Details | Diff
ebuild for sysfsutils-1.2.0-r1 (sysfsutils-1.2.0-r1.ebuild,1.01 KB, text/plain)
2005-03-05 13:43 UTC, Dominik Brodowski 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Brodowski 2005-03-05 13:41:46 UTC 
The check in libsysfs::write_attribute() which tests whether the value to be written into a sysfs attribute is already there should only trigger if the length of both strings is the same. This patch, already accepted by upstream for sysfsutils-1.4.0, is needed for pcmciautils to work correctly.


Reproducible: Always
Steps to Reproduce:
Comment 1 Dominik Brodowski 2005-03-05 13:42:39 UTC 
Created attachment 52742 [details, diff]
patch for libsysfs-1.2.0
Comment 2 Dominik Brodowski 2005-03-05 13:43:25 UTC 
Created attachment 52743 [details]
ebuild for sysfsutils-1.2.0-r1
Comment 3 Henrik Brix Andersen 2005-05-15 01:52:09 UTC 
Greg, can we get this patch merged into portage? It's the only issue holding back the addition of pcmciautils to portage (bug #84234).

If you want, I can add the patch and do the revision bump of sysfsutils.
Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev 2005-05-16 20:57:06 UTC 
Sorry, feel free to do it yourself, haven't had much gentoo specific time
lately :(
Comment 5 Henrik Brix Andersen 2005-05-20 05:54:33 UTC 
Added write_attribute() patch to sys-fs/sysfsutils-1.2.0-r1. Thanks.