Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 842030 - dev-util/drone: Add support for systemd
Summary: dev-util/drone: Add support for systemd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: install-systemd-unit
  Show dependency tree
 
Reported: 2022-05-01 21:28 UTC by Manuel Friedli
Modified: 2023-08-09 17:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for Drone 2.11.1 with systemd support (drone-2.11.1.ebuild,965 bytes, text/plain)
2022-05-01 21:28 UTC, Manuel Friedli
Details
Systemd unit file for Drone (drone-server.service,466 bytes, text/x-dbus-service)
2022-05-01 21:28 UTC, Manuel Friedli
Details
Diff from the official ebuild to my custom one (drone-2.11.1.ebuild.diff,736 bytes, patch)
2022-05-01 21:30 UTC, Manuel Friedli
Details | Diff
Systemd unit file for Drone (drone-server.service,466 bytes, text/plain)
2022-05-01 21:33 UTC, Manuel Friedli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Friedli 2022-05-01 21:28:06 UTC
Created attachment 775823 [details]
Ebuild for Drone 2.11.1 with systemd support

The current latest ebuild for dev-util/drone (version 2.11.1) does not ship with a systemd service file. Since I'm running a server with systemd, I'd really love to see that in the official tree.

I have created an ebuild (based off the official one) in my personal overlay, and it seems to be running fine on amd64: https://github.com/fritteli/gentoo-overlay/tree/master/dev-util/drone

I attach all relevant files to this bug report. I would be more than happy to receive feedback in order to improve the ebuild, and I would be most delighted if it could at one point be included in the official tree.
Comment 1 Manuel Friedli 2022-05-01 21:28:40 UTC
Created attachment 775826 [details]
Systemd unit file for Drone
Comment 2 Manuel Friedli 2022-05-01 21:30:27 UTC
Created attachment 775829 [details, diff]
Diff from the official ebuild to my custom one

Adding a diff between the official ebuild and my custom one to show the differences at one glance.
Comment 3 Manuel Friedli 2022-05-01 21:33:03 UTC
Created attachment 775832 [details]
Systemd unit file for Drone

Re-upload the systemd unit file as text/plain.
Comment 4 Manuel Friedli 2022-05-23 19:11:02 UTC
Is there anything I can do to help you include it in the official tree?
Comment 5 Manuel Friedli 2022-11-22 15:32:10 UTC
Is there anything I can help with to get this included in the official tree?
Would you like to have an update for drone 2.13.0?
Comment 6 Manuel Friedli 2023-02-26 22:12:59 UTC
I'd really love to see this in the main tree, then I could remove the custom ebuild from my overlay.
Is there anything I can help with to make this happen?

For drone 2.13.0, the exact same ebuild as for 2.11.1 can be used.
Comment 7 Manuel Friedli 2023-02-26 22:35:19 UTC
Created a pull request: https://github.com/gentoo/gentoo/pull/29817
Comment 8 Larry the Git Cow gentoo-dev 2023-08-09 17:47:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5b240ddba057505444ea9c5de375a5f5c232335

commit f5b240ddba057505444ea9c5de375a5f5c232335
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2023-08-09 17:41:58 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2023-08-09 17:45:37 +0000

    dev-util/drone: add 2.18.0
    
    Closes: https://bugs.gentoo.org/665748
    Closes: https://bugs.gentoo.org/842030
    Closes: https://github.com/gentoo/gentoo/pull/29817
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 dev-util/drone/Manifest                   |  2 +
 dev-util/drone/drone-2.18.0.ebuild        | 36 ++++++++++++++
 dev-util/drone/files/drone-server.conf    | 81 +++++++++++++++++++++++++++++++
 dev-util/drone/files/drone-server.confd   | 47 ------------------
 dev-util/drone/files/drone-server.initd   | 19 ++++++--
 dev-util/drone/files/drone-server.service | 25 ++++++++++
 6 files changed, 159 insertions(+), 51 deletions(-)