Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 841770 - sys-apps/systemd: Clang with FORTIFY_SOURCE=3 patch renders machine barely bootable, systemd-udevd dumps core
Summary: sys-apps/systemd: Clang with FORTIFY_SOURCE=3 patch renders machine barely bo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: systemwide-clang 847148 915000
  Show dependency tree
 
Reported: 2022-04-29 23:27 UTC by cyrillic
Modified: 2023-10-08 15:21 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge_info (file_841770.txt,7.65 KB, text/plain)
2022-05-24 14:11 UTC, Michael Egger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cyrillic 2022-04-29 23:27:14 UTC
sys-apps/systemd renders machine barely bootable, and systemd-udevd dumps core. This happens with both 250.4-r1 and 250.5 if the 250.4-fortify-source-3-malloc.patch is applied and gcc-12 is in use.

Reproducible: Always




# emerge --info
Portage 3.0.30 (python 3.10.4-final-0, default/linux/amd64/17.1/desktop/gnome/systemd, gcc-12.0.1, glibc-2.35-r4, 5.18.0-rc4 x86_64)
=================================================================
System uname: Linux-5.18.0-rc4-x86_64-AMD_Ryzen_Threadripper_2970WX_24-Core_Processor-with-glibc2.35
KiB Mem:    65841620 total,  62507424 free
KiB Swap:          0 total,         0 free
Head commit of repository qt: cc0782fc941179d3c378ca8f23717218e36836d3

Head commit of repository gentoo: ba4727593aaa9d453d13eeffab3ad34a34661328

sh bash 5.1_p16
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.4::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-lang/perl:             5.34.1-r3::gentoo
dev-lang/python:           3.10.4::gentoo
dev-lang/rust:             1.60.0::gentoo
dev-util/cmake:            3.23.1::gentoo
dev-util/meson:            0.62.1::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/openrc:           0.44.10::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          250.5::fixes
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.1-r1::gentoo
sys-devel/gcc:             12.0.1_p20220424::newstuff
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.1::gentoo
sys-devel/llvm:            14.0.1::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.17-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r4::gentoo
Repositories:

newstuff
    location: /mnt/repos/newstuff
    masters: gentoo
    priority: -1030
    eclass-overrides: fixes

qt
    location: /mnt/repos/qt
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/proj/qt.git
    masters: gentoo
    priority: -1020
    eclass-overrides: fixes

gnomelive
    location: /mnt/repos/gnomelive
    masters: gentoo
    priority: -1010
    eclass-overrides: fixes

gentoo
    location: /mnt/repos/gentoo
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/gentoo.git
    priority: -1000
    eclass-overrides: fixes

crossdev
    location: /mnt/repos/crossdev
    masters: gentoo
    eclass-overrides: fixes

fixes
    location: /mnt/repos/fixes
    masters: gentoo
    priority: 10
    eclass-overrides: fixes

Installed sets: @clang, @gnome, @qt6, @system
ACCEPT_KEYWORDS="* amd64 ~*"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nocona -mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=nocona -mtune=native -O2 -pipe"
DISTDIR="/mnt/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/var/tmp/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl alsa amd64 bluetooth bluray boost brotli bzip2 cairo caps cdr colord cpudetection css cups curl custom-cflags cxx dbus drm dts dvd eds egl encode exif expat fbcon ffmpeg flac flickr fontconfig fortran gdbm geolocation gif glamor glib gnome gnome-keyring gnutls gpm graphite gssapi gstreamer gtk gtk3 harfbuzz heif ibus icu idn imagemagick introspection ipv6 jpeg jpeg2k jpegxl kmod kms lcms libass libglvnd libinput libnotify lz4 lzma mp3 mpi nautilus ncurses networkmanager nls nptl numa ocamlopt ogg opencl opencv openexr opengl openmp openssl opus orc pam pango pcre pdf png policykit postproc postscript pulseaudio python qml readline samba speex spell split-usr ssl ssp svg systemd tcl telepathy theora threads tiff tk tools tracker truetype udev unicode upnp-av usb utils v4l vala vorbis vpx vulkan wayland webp x264 x265 xcb xkb xml xmp xv xvmc zlib zstd" ABI_X86="64" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3" CURL_SSL="openssl" ELIBC="glibc" INPUT_DEVICES="libinput wacom" KERNEL="linux" L10N="en" LLVM_TARGETS="AMDGPU BPF X86" LUA_SINGLE_TARGET="lua5-4" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="amdgpu intel nouveau radeon radeonsi"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 cyrillic 2022-04-29 23:28:50 UTC
I was able to recover by commenting out that patch, and rebuilding systemd.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-29 23:29:59 UTC
It'd be helpful if you could share the coredump, but I'm happy to drop it for now.
Comment 3 cyrillic 2022-04-29 23:35:33 UTC
Apr 29 18:39:05 cyan systemd-logind[1105]: New seat seat0.
Apr 29 18:39:05 cyan systemd[1]: Started User Login Management.
Apr 29 18:39:05 cyan systemd-coredump[1100]: [🡕] Process 997 (systemd-udevd) of user 0 dumped core.
                                             
                                             Module linux-vdso.so.1 with build-id 324459c7be7817181a126eb6e5a56ba612a8b937
                                             Module libgpg-error.so.0 without build-id.
                                             Module libz.so.1 without build-id.
                                             Module ld-linux-x86-64.so.2 without build-id.
                                             Module libm.so.6 without build-id.
                                             Module liblzma.so.5 without build-id.
                                             Module libzstd.so.1 without build-id.
                                             Module libpam.so.0 without build-id.
                                             Module libcrypto.so.1.1 without build-id.
                                             Module libmount.so.1 without build-id.
                                             Module liblz4.so.1 without build-id.
                                             Module libgcrypt.so.20 without build-id.
                                             Module libcrypt.so.2 without build-id.
                                             Module libcap.so.2 without build-id.
                                             Module libacl.so.1 without build-id.
                                             Module libc.so.6 without build-id.
                                             Module libblkid.so.1 without build-id.
                                             Module libkmod.so.2 without build-id.
                                             Module libsystemd-shared-250.so without build-id.
                                             Module udevadm without build-id.
                                             Stack trace of thread 997:
                                             #0  0x00007f32f40eac1c n/a (libc.so.6 + 0x8dc1c)
                                             #1  0x00007f32f409adc2 raise (libc.so.6 + 0x3ddc2)
                                             #2  0x00007f32f40851ea abort (libc.so.6 + 0x281ea)
                                             #3  0x00007f32f43f3b42 log_assert_failed (libsystemd-shared-250.so + 0x150b42)
                                             #4  0x00007f32f4463cef n/a (libsystemd-shared-250.so + 0x1c0cef)
                                             #5  0x00007f32f4463a82 device_get_properties_nulstr (libsystemd-shared-250.so + 0x1c0a>
                                             #6  0x00007f32f4462745 device_monitor_send_device (libsystemd-shared-250.so + 0x1bf745)
                                             #7  0x00005578da369837 n/a (udevadm + 0x1e837)
                                             #8  0x00005578da368cf1 n/a (udevadm + 0x1dcf1)
                                             #9  0x00007f32f44ac4a4 n/a (libsystemd-shared-250.so + 0x2094a4)
                                             #10 0x00007f32f44abff0 sd_event_dispatch (libsystemd-shared-250.so + 0x208ff0)
                                             #11 0x00007f32f44acb40 sd_event_run (libsystemd-shared-250.so + 0x209b40)
                                             #12 0x00007f32f44acd4f sd_event_loop (libsystemd-shared-250.so + 0x209d4f)
                                             #13 0x00005578da366a19 n/a (udevadm + 0x1ba19)
                                             #14 0x00005578da3601a7 n/a (udevadm + 0x151a7)
                                             #15 0x00007f32f4085eaa n/a (libc.so.6 + 0x28eaa)
                                             #16 0x00007f32f4085f65 __libc_start_main (libc.so.6 + 0x28f65)
                                             #17 0x00005578da360051 n/a (udevadm + 0x15051)
                                             ELF object binary architecture: AMD x86-64
Apr 29 18:39:05 cyan systemd[1]: systemd-udevd.service: Main process exited, code=dumped, status=6/ABRT
Apr 29 18:39:05 cyan systemd[1]: systemd-udevd.service: Killing process 1004 (systemd-udevd) with signal SIGKILL.
Comment 4 Larry the Git Cow gentoo-dev 2022-04-30 00:30:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=241570c597a6878e55f3e40ea357dfb3120b7599

commit 241570c597a6878e55f3e40ea357dfb3120b7599
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-30 00:30:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-30 00:30:21 +0000

    sys-apps/systemd: drop FORTIFY_SOURCE=3 patch for now
    
    May cause runtime issues for some without using FORTIFY_SOURCE? (Not seen
    this myself but let's be safe.)
    
    Note that reported issue is only w/ GCC 12 anyway which is not yet
    released.
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/250.4-fortify-source-3-malloc.patch      | 42 ----------------------
 ...emd-250.4-r1.ebuild => systemd-250.4-r2.ebuild} |  1 -
 ...ystemd-250.5.ebuild => systemd-250.5-r1.ebuild} |  1 -
 3 files changed, 44 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-30 00:31:42 UTC
Could you get some debugging symbols on libc, systemd please?

Also, SIGKILL -- what instruction? Does dmesg show it?

Can you reproduce the error by running a binary on the command line at all?
Comment 6 cyrillic 2022-04-30 00:43:50 UTC
This was just the remains in systemd-journal. The machine was not very useable while the problem was happening. Sorry I am not really set up for debugging this sort of thing.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-30 00:58:30 UTC
(In reply to cyrillic from comment #6)
> This was just the remains in systemd-journal. The machine was not very
> useable while the problem was happening. Sorry I am not really set up for
> debugging this sort of thing.

No problem. Thanks for reporting either way. When systemd-251_rc2 is out, would you mind trying it out? It'll contain the Bad Patch.
Comment 8 cyrillic 2022-04-30 01:09:14 UTC
(In reply to Sam James from comment #7)
> No problem. Thanks for reporting either way. When systemd-251_rc2 is out,
> would you mind trying it out? It'll contain the Bad Patch.

Sounds like fun ;)
Comment 9 cyrillic 2022-05-01 19:50:40 UTC
Whoops, maybe I should pay closer attention before I go blaming gcc.

I was actually using clang-14 to compile systemd when things went sideways, so I tried the patch with gcc-12 this time, and it seems to be fine.
Comment 10 Manuel Nickschas 2022-05-02 07:31:15 UTC
I just wanted to say, I am seeing this issue with Clang 14.0.1 (on a Clang/libc++ system), I have worked around this for now by compiling systemd with GCC (and will now update to the version without the fortiy patch).

The bug seems to be this issue reported upstream:

https://github.com/systemd/systemd/issues/23150

The assertion mentioned is the same I am seeing, and the reporter also bisected it to the fortify patch.

I didn't do any further investigation as I need my machine up an running, but hopefully this already helps a bit.
Comment 11 cyrillic 2022-05-06 00:44:53 UTC
Same results with sys-apps/systemd-251_rc2

sys-devel/gcc-12.0.1_p20220430 : compiles and runs fine

sys-devel/clang-14.0.3 : compiles fine, crash-n-burn at runtime

Would this be considered an LLVM bug ?
or
Is this patch trying to do something unsavory with the memory allocator ?
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-06 01:24:56 UTC
(In reply to cyrillic from comment #11)
> Same results with sys-apps/systemd-251_rc2
> 
> sys-devel/gcc-12.0.1_p20220430 : compiles and runs fine
> 
> sys-devel/clang-14.0.3 : compiles fine, crash-n-burn at runtime
> 
> Would this be considered an LLVM bug ?
> or
> Is this patch trying to do something unsavory with the memory allocator ?

I think it's https://github.com/systemd/systemd/issues/23150 as Manuel kindly pointed out and it seems likely to be an LLVM bug, but I'm not sure yet...

Definitely really odd. Thanks for trying rc2 so quickly by the way!
Comment 13 cyrillic 2022-05-12 09:59:47 UTC
I have reversed the patch, and applied it to systemd-251_rc2.
Compiling systemd with clang is useable once again.

I imagine this will only be a problem when Gentoo starts defaulting to -D_FORTIFY_SOURCES=3.
Comment 14 Kenton Groombridge gentoo-dev 2022-05-23 02:20:49 UTC
Also now seeing this with systemd-251 and clang/LLVM-14.0.3. Reverting the patch or compiling with gcc fixes the issue on my system.

Should we default to reverting the problematic commit when building with clang for now?
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-23 02:34:53 UTC
(In reply to Kenton Groombridge from comment #14)
> Also now seeing this with systemd-251 and clang/LLVM-14.0.3. Reverting the
> patch or compiling with gcc fixes the issue on my system.
> 
> Should we default to reverting the problematic commit when building with
> clang for now?

I don't love it but it's fine with me. Let's see what floppym says.

Is this only with you setting F_S=3 or simply by building with Clang? It affects the urgency given we'll only have a handful of people doing the former, especially with Clang, but we have a surprising number of overall Clang users.
Comment 16 Mike Gilbert gentoo-dev 2022-05-23 14:04:00 UTC
It seems that if we revert this commit, we break GCC 12.

My preference would be to do nothing unless some action is taken upstream.
Comment 17 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-05-23 15:53:27 UTC
(In reply to Mike Gilbert from comment #16)
> It seems that if we revert this commit, we break GCC 12.
> 
> My preference would be to do nothing unless some action is taken upstream.

It won't break 12 unless FS3 is set which we aren't doing by default.
Comment 18 Mike Gilbert gentoo-dev 2022-05-23 16:05:10 UTC
(In reply to Sam James from comment #17)
> It won't break 12 unless FS3 is set which we aren't doing by default.

If I understand correctly, the same goes for clang; we don't enable FS3 by default anywhere.
Comment 19 Kenton Groombridge gentoo-dev 2022-05-24 02:28:11 UTC
(In reply to Sam James from comment #15)
> Is this only with you setting F_S=3 or simply by building with Clang? It
> affects the urgency given we'll only have a handful of people doing the
> former, especially with Clang, but we have a surprising number of overall
> Clang users.

For me it was simply building with clang. I do have a few exotic flags set but F_S=3 is not one of them.
Comment 20 Mike Gilbert gentoo-dev 2022-05-24 03:32:08 UTC
(In reply to Kenton Groombridge from comment #19)

Please provide emerge --info.
Comment 21 Michael Egger 2022-05-24 14:11:12 UTC
Created attachment 780566 [details]
emerge_info

Same issue here with systemd-251, global clang and w/o FORITFY_SOURCE set.
Attached emerge --info
Comment 22 Mike Gilbert gentoo-dev 2022-05-24 16:00:13 UTC
If this affects clang without -D_FORTIFY_SOURCE=3, I guess I'm ok with reverting the commit.
Comment 23 Larry the Git Cow gentoo-dev 2022-05-24 22:35:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eb84c4b6a972b074bc60f64d3348e93602795df1

commit eb84c4b6a972b074bc60f64d3348e93602795df1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-24 22:27:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-24 22:35:50 +0000

    sys-apps/systemd: add 251.1
    
    - Revert FORTIFY_SOURCE=3 patch for now as it breaks Clang (even without
    setting F_S=3, or seemingly F_S at all, as we don't patch Clang to add that
    in the way we do with GCC)
    
    - Turn off F_S=3 accordingly given we've had to revert the patch which
    fixes support for it.
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/systemd/Manifest                          |   1 +
 .../files/251-revert-fortify-source-3-fix.patch    |  40 ++
 sys-apps/systemd/systemd-251.1.ebuild              | 530 +++++++++++++++++++++
 sys-apps/systemd/systemd-9999.ebuild               |  20 +-
 4 files changed, 590 insertions(+), 1 deletion(-)
Comment 24 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-03 07:34:18 UTC
*** Bug 847892 has been marked as a duplicate of this bug. ***
Comment 25 Larry the Git Cow gentoo-dev 2022-06-28 02:10:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c7c85f9333ee05f0f4b7ad757b562a62037fe44

commit 4c7c85f9333ee05f0f4b7ad757b562a62037fe44
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-06-28 02:09:53 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-28 02:09:58 +0000

    sys-apps/systemd: drop obsolete F_S=3 revert
    
    Reverted upstream.
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/systemd/systemd-9999.ebuild | 3 ---
 1 file changed, 3 deletions(-)
Comment 26 Larry the Git Cow gentoo-dev 2023-01-11 07:50:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2da823e00fce128d20b098ab5abef4838084e24f

commit 2da823e00fce128d20b098ab5abef4838084e24f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-11 07:37:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-11 07:49:43 +0000

    sys-apps/systemd-utils: add note re FORTIFY_SOURCE=3 in 251.10-r1
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/systemd-utils/systemd-utils-251.10-r1.ebuild | 9 +++++++++
 1 file changed, 9 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c279c7734179483274ddd919d9d21c561f854cc

commit 3c279c7734179483274ddd919d9d21c561f854cc
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-11 07:32:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-11 07:48:30 +0000

    sys-apps/systemd: drop FORTIFY_SOURCE=3 hacks in 9999, add note to 252.4-r1
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/systemd/systemd-252.4-r1.ebuild |  9 +++++++++
 sys-apps/systemd/systemd-9999.ebuild     | 18 ++----------------
 2 files changed, 11 insertions(+), 16 deletions(-)
Comment 27 Larry the Git Cow gentoo-dev 2023-01-30 00:55:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1683dc815095d72d61fe9246f3b7106a80d9bf6

commit b1683dc815095d72d61fe9246f3b7106a80d9bf6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-30 00:54:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-30 00:55:48 +0000

    sys-apps/systemd: add 252.5
    
    The F_S=3 fixes got backported to 252.x in this release.
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/systemd/Manifest             |   1 +
 sys-apps/systemd/systemd-252.5.ebuild | 507 ++++++++++++++++++++++++++++++++++
 2 files changed, 508 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0f66891a0dbcf460a568e6edd12f93515727b6c

commit c0f66891a0dbcf460a568e6edd12f93515727b6c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-30 00:47:54 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-30 00:55:47 +0000

    sys-apps/systemd-utils: add 252.5
    
    The F_S=3 fixes got backported to 252.x in this release.
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/systemd-utils/Manifest                   |   1 +
 sys-apps/systemd-utils/systemd-utils-252.5.ebuild | 508 ++++++++++++++++++++++
 2 files changed, 509 insertions(+)
Comment 28 Larry the Git Cow gentoo-dev 2023-01-30 17:37:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f06cb39a5d25c754c01e96313f76dc802e361995

commit f06cb39a5d25c754c01e96313f76dc802e361995
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-30 01:05:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-30 17:37:03 +0000

    toolchain-funcs.eclass: add tc-enables-fortify-source for FORTIFY_SOURCE
    
    As Zero_Chaos reported on IRC, the check we had wasn't good enough in systemd*
    (before we were able to remove it), as it wouldn't fire for e.g. -Os. While we
    could've changed it to fail safe (always unset, then set a lower F_S if possible),
    let's add a proper helper instead to the eclass.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847148
    Bug: https://bugs.gentoo.org/876893
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/toolchain-funcs.eclass | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Comment 29 Larry the Git Cow gentoo-dev 2023-08-06 11:49:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4edc739c2a9e4aa6f14b2489dc4bf19693542081

commit 4edc739c2a9e4aa6f14b2489dc4bf19693542081
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:45:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-06 11:48:43 +0000

    dev-db/mysql: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-db/mysql/mysql-8.0.32-r2.ebuild | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc9abc19ceb0c3bb7d2632394c38f4772f490ca8

commit cc9abc19ceb0c3bb7d2632394c38f4772f490ca8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:43:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-06 11:48:37 +0000

    sys-apps/acl: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847280
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/acl/acl-2.3.1-r1.ebuild | 6 ++----
 sys-apps/acl/acl-2.3.1-r2.ebuild | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a84e57a1963e12919d9b843324d70b12e992bc7

commit 5a84e57a1963e12919d9b843324d70b12e992bc7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:41:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-06 11:47:53 +0000

    dev-qt/qtcore: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847145
    Bug: https://bugs.gentoo.org/852974
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-qt/qtcore/qtcore-5.15.10-r1.ebuild | 5 +++--
 dev-qt/qtcore/qtcore-5.15.10.ebuild    | 7 +++----
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 30 Larry the Git Cow gentoo-dev 2023-10-08 15:21:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=ec1cae0ebc814755c9cf1dd5b5a70d1777d422b8

commit ec1cae0ebc814755c9cf1dd5b5a70d1777d422b8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-06 11:41:48 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-10-08 15:20:41 +0000

    dev-qt/qtcore: use tc-enables-fortify-source
    
    Better than fragile optimisation level checking.
    
    Bug: https://bugs.gentoo.org/841770
    Bug: https://bugs.gentoo.org/847145
    Bug: https://bugs.gentoo.org/852974
    Signed-off-by: Sam James <sam@gentoo.org>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtcore/qtcore-5.15.11.9999.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)