Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839177 - sys-apps/kexec-tools: automated shellcheck found errors
Summary: sys-apps/kexec-tools: automated shellcheck found errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 11:06 UTC by shellbugbot
Modified: 2022-04-22 17:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shellbugbot 2022-04-18 11:06:01 UTC
Shellckeck found errors in one or more shellscripts provided by sys-apps/kexec-tools.

Kindly refer to the findings below and the shellcheck wiki for further details:

------------------------------------------------
script: /usr/portage/sys-apps/kexec-tools/kexec-tools-9999.ebuild:117

	if [[ ${n_root_args} > 1 && "${has_rootpart_set}" == "no"  ]]; then
                             ^
error: > is for string comparisons. Use -gt instead. (https://github.com/koalaman/shellcheck/wiki/SC2071)

------------------------------------------------
script: /usr/portage/sys-apps/kexec-tools/kexec-tools-2.0.23.ebuild:117

	if [[ ${n_root_args} > 1 && "${has_rootpart_set}" == "no"  ]]; then
                             ^
error: > is for string comparisons. Use -gt instead. (https://github.com/koalaman/shellcheck/wiki/SC2071)

------------------------------------------------
script: /usr/portage/sys-apps/kexec-tools/kexec-tools-2.0.22.ebuild:117

	if [[ ${n_root_args} > 1 && "${has_rootpart_set}" == "no"  ]]; then
                             ^
error: > is for string comparisons. Use -gt instead. (https://github.com/koalaman/shellcheck/wiki/SC2071)

This is an automated bug report. Conservative settings were used to minimize false-positives but there's still a chance that the above list contains non-issues.
Running shellcheck again with default settings could detect other possible issues.

References:
[1] this script: https://github.com/heeplr/gentoo-shellbug
[2] shellcheck: https://www.shellcheck.net/
Comment 1 Larry the Git Cow gentoo-dev 2022-04-22 17:54:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=183cd801507244a3c1f75b33914cd7f96c3c5834

commit 183cd801507244a3c1f75b33914cd7f96c3c5834
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-22 17:54:27 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-22 17:54:36 +0000

    sys-apps/kexec-tools: fix shellcheck errors in comparison
    
    Closes: https://bugs.gentoo.org/839177
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/kexec-tools/kexec-tools-2.0.22.ebuild | 4 ++--
 sys-apps/kexec-tools/kexec-tools-2.0.23.ebuild | 4 ++--
 sys-apps/kexec-tools/kexec-tools-9999.ebuild   | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)