Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 837146 - dev-embedded/avr-libc-2.0.0 uses banned EAPI 5
Summary: dev-embedded/avr-libc-2.0.0 uses banned EAPI 5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: EAPI5Removal
  Show dependency tree
 
Reported: 2022-04-07 18:04 UTC by Ulrich Müller
Modified: 2022-06-08 20:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bump to 2.1.0 and EAPI=8 (avr-libc-2.1.0.ebuild,1.93 KB, text/plain)
2022-05-22 18:25 UTC, Nils Freydank
Details
Bump to 2.1.0 and EAPI=8 (0001-dev-embedded-avr-libc-Bump-to-2.1.0-drop-IUSE-doc.patch,4.57 KB, patch)
2022-06-08 20:22 UTC, Nils Freydank
Details | Diff
Drop the old EAPI=5 ebuild (0002-dev-embedded-avr-libc-Drop-the-old-package-with-EAPI.patch,4.55 KB, patch)
2022-06-08 20:23 UTC, Nils Freydank
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2022-04-07 18:04:17 UTC
Please port to newer EAPI.
Comment 1 Nils Freydank 2022-05-22 18:25:55 UTC
Created attachment 780200 [details]
bump to 2.1.0 and EAPI=8

(In reply to Ulrich Müller from comment #0)
> Please port to newer EAPI.

I've bumped the ebuild on my local machine to to 2.1.0 and EAPI="8". I'll attach the bumped ebuild as a DRAFT here.

Please note two things:
1st I only compiled code with that libc yet and did no runtime tests so far.
2nd There is a wrong signature for the "user manual" distfile. I've notified upstream by mail some minutes ago. I'd like to wait a bunch of days for their response and either bump the package without that manual or a fixed archive (or signature).
Comment 2 Ulrich Müller gentoo-dev 2022-05-22 19:12:37 UTC
(In reply to Nils Freydank from comment #1)
> I've bumped the ebuild on my local machine to to 2.1.0 and EAPI="8". I'll
> attach the bumped ebuild as a DRAFT here.

Thank you.

Even though these changes are barely copyrightable, could you please add a Signed-off-by line for completeness:
https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin
(Posting it as a comment to this bug may be the easiest way.)

> Please note two things:
> 1st I only compiled code with that libc yet and did no runtime tests so far.
> 2nd There is a wrong signature for the "user manual" distfile. I've notified
> upstream by mail some minutes ago. I'd like to wait a bunch of days for
> their response and either bump the package without that manual or a fixed
> archive (or signature).

You mean this, I suppose?

$ gpg --verify avr-libc-user-manual-2.1.0.tar.bz2.sig 
gpg: assuming signed data in 'avr-libc-user-manual-2.1.0.tar.bz2'
gpg: Signature made Sat 29 Jan 2022 00:28:33 CET
gpg:                using RSA key 56628323218C669FF578705C7E9EADC3030D34EB
gpg: BAD signature from "Joerg Wunsch <j.gnu@uriah.heep.sax.de>" [unknown]
Comment 3 Ulrich Müller gentoo-dev 2022-06-08 12:55:28 UTC
Ping, any news?
Comment 4 Nils Freydank 2022-06-08 20:22:58 UTC
Created attachment 783668 [details, diff]
Bump to 2.1.0 and EAPI=8
Comment 5 Nils Freydank 2022-06-08 20:23:17 UTC
Created attachment 783671 [details, diff]
Drop the old EAPI=5 ebuild
Comment 6 Nils Freydank 2022-06-08 20:29:45 UTC
(In reply to Ulrich Müller from comment #3)
> Ping, any news?

Pong. Upstream responded quickly first but we've got no solution yet, so I propose to drop IUSE="doc" for now and restore it when distfiles and signatures match again.

FWIW, that documentation seems to be some rather harmless doxygen-generated HTML files, but I can't be 100% sure without a full review. Manpages are not affected.

I added the two patches (bump plus cleanup of 2.0.0) but opened also a PR on github.com:

https://github.com/gentoo/gentoo/pull/25818
Comment 7 Larry the Git Cow gentoo-dev 2022-06-08 20:50:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b3e172fddebda88348cdde3068e961525ae2d5e

commit 5b3e172fddebda88348cdde3068e961525ae2d5e
Author:     Nils Freydank <holgersson@posteo.de>
AuthorDate: 2022-06-08 20:21:22 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-06-08 20:49:22 +0000

    dev-embedded/avr-libc: Drop the old package with EAPI=5
    
    Closes: https://bugs.gentoo.org/837146
    Signed-off-by: Nils Freydank <holgersson@posteo.de>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 dev-embedded/avr-libc/Manifest              |  3 --
 dev-embedded/avr-libc/avr-libc-2.0.0.ebuild | 78 -----------------------------
 2 files changed, 81 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e61d77fa08f6a640921e741017895740857fcd63

commit e61d77fa08f6a640921e741017895740857fcd63
Author:     Nils Freydank <holgersson@posteo.de>
AuthorDate: 2022-06-08 20:21:21 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-06-08 20:49:17 +0000

    dev-embedded/avr-libc: Bump to 2.1.0, drop IUSE="doc"
    
    Bump to the new version and EAPI 8. There is an issue with upstream's
    distfile signature for the HTML documentation, so dropping for now. IMHO we
    should restore the flag and doc installation as soon as upstream's signature
    is fixed.
    Man pages are not affected as they are part of the main distfiles archive.
    
    Bug: https://bugs.gentoo.org/837146
    Signed-off-by: Nils Freydank <holgersson@posteo.de>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 dev-embedded/avr-libc/Manifest              |  2 +
 dev-embedded/avr-libc/avr-libc-2.1.0.ebuild | 72 +++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)
Comment 8 Ulrich Müller gentoo-dev 2022-06-08 20:51:26 UTC
Thanks!