Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836329 - dev-util/crash fails to open vmlinux images from recent kernels
Summary: dev-util/crash fails to open vmlinux images from recent kernels
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Yixun Lan
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2022-03-28 16:21 UTC by Pierre Asselin
Modified: 2023-11-23 12:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix 'cannot resolve "sys_open"' in dev-util/crash-8.0.0 on x86 (crash-patch.txt,848 bytes, text/plain)
2022-03-28 16:21 UTC, Pierre Asselin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Asselin 2022-03-28 16:21:35 UTC
Created attachment 768081 [details]
Fix 'cannot resolve "sys_open"' in dev-util/crash-8.0.0 on x86

on x86 the command
  crash vmlinux vmcore
fails with an error message
  cannot resolve "sys_open"

Probably affects <=dev-util/crash-8.0.0 ;  seen on -8.0.0 .

Issue is that kernel symbols like "sys_xyz" became "__ia32_sys_xyz" and crash looks for a few of them under the old name in x86.c:x86_omit_frame_pointer().  

Fix is to copy the logic from x86_64:x86_64_framepointer_init(), which handles the same issue for amd64.  Patch attached.  File x86.c is at the top of the crash source tree.  Patch was submitted upstream.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-28 16:31:46 UTC
Could you link to the upstream submission? Thanks!
Comment 2 Pierre Asselin 2022-03-29 03:17:18 UTC
Upstream submission at
https://github.com/crash-utility/crash/issues/116
Comment 3 Pierre Asselin 2022-03-29 13:46:59 UTC
Ahem.  Upstream kindly points out that the patch should say
    for(i= 0; i<6; i++) {

Please patch the patch...  Sorry about that.
Comment 4 Larry the Git Cow gentoo-dev 2022-04-02 08:24:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53a18b3469994b032ddb6b199aaba3e67872f700

commit 53a18b3469994b032ddb6b199aaba3e67872f700
Author:     Yixun Lan <dlan@gentoo.org>
AuthorDate: 2022-04-02 08:21:31 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2022-04-02 08:23:41 +0000

    dev-util/crash: fix un-resolvable sys_open symbol issue
    
    always pull upstream's latest fixes/patches
    thanks "Pierre Asselin" for reporting this
    
    Closes: https://bugs.gentoo.org/836329
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 dev-util/crash/Manifest              |  1 +
 dev-util/crash/crash-8.0.0-r1.ebuild | 43 ++++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
Comment 5 Pierre Asselin 2022-04-30 20:08:04 UTC
This bug has returned in dev-util/crash-8.0.1
Comment 6 Yixun Lan archtester gentoo-dev 2022-12-19 02:27:30 UTC
sorry, for 8.0.1, I've dropped the patch accidently,
should be fixed in 8.0.2, please try again
Comment 7 Pierre Asselin 2022-12-28 18:35:28 UTC
(In reply to Yixun Lan from comment #6)
> sorry, for 8.0.1, I've dropped the patch accidently,
> should be fixed in 8.0.2, please try again

Yes, fixed in 8.0.2.  Thanks.
Comment 8 Larry the Git Cow gentoo-dev 2023-11-23 12:39:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fb203fb925ec7b6bd8cca6cbe380d85834fd681

commit 5fb203fb925ec7b6bd8cca6cbe380d85834fd681
Author:     Yixun Lan <dlan@gentoo.org>
AuthorDate: 2023-11-23 12:37:13 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2023-11-23 12:39:33 +0000

    dev-util/crash: fix un-resolvable "sys_open" symbol issue
    
    fixed it as previously version bump dropped unintentionally
    
    Bug: https://bugs.gentoo.org/836329
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 dev-util/crash/crash-8.0.4.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)