Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836067 - mail-filter/spamassassin: uses variables banned in scope (VariableScope)
Summary: mail-filter/spamassassin: uses variables banned in scope (VariableScope)
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Philippe Chaintreuil
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 836052 778806
Blocks: forbidden-variable-use
  Show dependency tree
 
Reported: 2022-03-26 03:39 UTC by Sam James
Modified: 2024-06-11 06:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-26 03:39:07 UTC
This package uses variables banned in some scopes. This may stop working in future versions of Portage.

$ pkgcheck scan -k VariableScope mail-filter/spamassassin
mail-filter/spamassassin
  VariableScope: version 3.4.5-r1: variable 'D' used in 'src_configure', line 139
  VariableScope: version 3.4.6-r1: variable 'D' used in 'src_configure', line 139
Comment 1 Philippe Chaintreuil 2022-05-04 13:56:31 UTC
Not sure how to address this.  See [1] for details/background.

Seems like this is endemic to traditional Perl build systems.

I'm just going to watch bug #778806 and bug #836052, and follow their lead whenever (if ever) they act upon this issue.


[1] https://forums.gentoo.org/viewtopic-p-8706164.html
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-11 02:55:36 UTC
I think you should be able to copy what I did in https://bugs.gentoo.org/778806#c3 now.
Comment 3 Philippe Chaintreuil 2024-05-11 18:35:12 UTC
Pull request created.

I just deleted the `${D}` line in `src_configure`.  Hoping that's right.  Gives me the same files (same MD5s) in the same locations without it now.

I made rev-bumps instead of fixing in-place so I users have some place to revert to if I'm wrong.

Will remove the old revs once these new ones are stabilized.  Leaving the bug open  until then.
Comment 4 Larry the Git Cow gentoo-dev 2024-06-11 06:01:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83296c79ee741ed5b5814c4947f99ba98789c4a4

commit 83296c79ee741ed5b5814c4947f99ba98789c4a4
Author:     Philippe Chaintreuil <gentoo_bugs_peep@parallaxshift.com>
AuthorDate: 2024-05-11 18:21:35 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-06-11 06:01:22 +0000

    mail-filter/spamassassin: Address VariableScope warnings
    
    - Removed 4.0.0-r3 because it's moot now that -r4 is stable
    - Bumped revs instead of fixing in place because all existing
      ebuilds have the VariableScope warning.  If I fixed them
      in place, users would have no easy way to fallback if an
      issue is found.
    - Plan is to remove the pre-existing revs once these new
      revs have been stabilized.
    - I also re-ordered some ebuild variables in 3.4.6-r3 to
      avoid ordering warnings.
    - Note: git's wrong about the -r3 -> -r5 rename.
    
    Bug: https://bugs.gentoo.org/836067
    Closes: https://github.com/gentoo/gentoo/pull/36644
    Signed-off-by: Philippe Chaintreuil <gentoo_bugs_peep@parallaxshift.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../spamassassin/spamassassin-3.4.6-r3.ebuild      | 321 ++++++++++++++++++++
 ....0.0-r3.ebuild => spamassassin-4.0.0-r5.ebuild} |   4 +-
 .../spamassassin/spamassassin-4.0.1-r1.ebuild      | 337 +++++++++++++++++++++
 3 files changed, 660 insertions(+), 2 deletions(-)