Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 836012 - sys-kernel/genkernel-4.2.6-r2: Utils fail to build with slibtool
Summary: sys-kernel/genkernel-4.2.6-r2: Utils fail to build with slibtool
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL: https://github.com/gentoo/genkernel/p...
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2022-03-25 20:00 UTC by orbea
Modified: 2022-08-02 00:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix the build for cryptsetup and util-linux (genkernel-4.2.6-utils-slibtool.patch,2.60 KB, patch)
2022-03-25 20:09 UTC, orbea
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description orbea 2022-03-25 20:00:53 UTC
When using sys-devel/slibtool to build utils for the initramfs it will fail when it installs a slibtool wrapper script instead of the real binary. This happens because it these binaries are installed manually instead of using the install target where slibtool and GNU libtool will place the files in different places.

The URL is an upstream PR to fix this issue by dynamically finding the executable to install.

Reproducible: Always

Steps to Reproduce:
1. Enable slibtool for genkernel with an argument like '--utils-make="$HOME"/bin/tools/make' which is the following wrapper script for make.

#!/bin/sh
export MAKE='make LIBTOOL=rlibtool'
export MAKEFLAGS='LIBTOOL=rlibtool'
make "$@"

2. Build a kernel with genkernel where it will build utils for the initramfs such as util-linux or cryptsetup.
3. Fails when strip(1) is given text files.
Actual Results:  
The build will install slibtool wrapper scripts instead of the actual binary which then fails when strip(1) is given a text file instead of a binary.

Expected Results:  
It should correctly install the binary file correctly.
Comment 1 orbea 2022-03-25 20:09:49 UTC
Created attachment 767813 [details, diff]
Patch to fix the build for cryptsetup and util-linux

Upstream PR - https://github.com/gentoo/genkernel/pull/33
Comment 3 Larry the Git Cow gentoo-dev 2022-08-02 00:22:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0693a3b58cd9a217b11f6a3f09fd635f88e661c5

commit 0693a3b58cd9a217b11f6a3f09fd635f88e661c5
Author:     orbea <orbea@riseup.net>
AuthorDate: 2022-07-10 22:22:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-02 00:21:40 +0000

    sys-kernel/genkernel: Fix utils build with slibtool
    
    Bug: https://bugs.gentoo.org/836012
    Upstream-PR: https://github.com/gentoo/genkernel/pull/33
    Closes: https://github.com/gentoo/gentoo/pull/26333
    Signed-off-by: Sam James <sam@gentoo.org>

 .../genkernel/files/genkernel-4.2.6-slibtool.patch | 106 +++++++
 sys-kernel/genkernel/genkernel-4.2.6-r7.ebuild     | 327 +++++++++++++++++++++
 2 files changed, 433 insertions(+)