Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835828 - www-client/seamonkey-2.53.11 fails to build with media-libs/dav1d-1.0.0
Summary: www-client/seamonkey-2.53.11 fails to build with media-libs/dav1d-1.0.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Myckel Habets
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: 835807
  Show dependency tree
 
Reported: 2022-03-23 06:31 UTC by Attila Tóth
Modified: 2022-03-26 13:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
seamonkey-2.53.11-dav1d-1.0.0.patch (seamonkey-2.53.11-dav1d-1.0.0.patch,989 bytes, patch)
2022-03-23 06:33 UTC, Attila Tóth
Details | Diff
Updated conditional patch. (seamonkey-2.53.11-dav1d-1.0.0.patch,1.56 KB, patch)
2022-03-23 09:13 UTC, Myckel Habets
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Tóth 2022-03-23 06:31:44 UTC
media-libs/dav1d-1.0.0 breakage

Reproducible: Always
Comment 1 Attila Tóth 2022-03-23 06:33:38 UTC
Created attachment 767613 [details, diff]
seamonkey-2.53.11-dav1d-1.0.0.patch

Unconditional patch to handle the situation.
Comment 2 Myckel Habets 2022-03-23 09:12:38 UTC
Thank you for the patch. I've taken the liberty to make it conditional, so that it should support current stable and unstable media-libs/dav1d.

Please feel free to test it and comment if there are any issues.
Comment 3 Myckel Habets 2022-03-23 09:13:45 UTC
Created attachment 767641 [details, diff]
Updated conditional patch.
Comment 4 Joonas Niilola gentoo-dev 2022-03-24 07:26:36 UTC
(In reply to Myckel Habets from comment #3)
> Created attachment 767641 [details, diff] [details, diff]
> Updated conditional patch.

Oo this would've been a much cleaner solution for firefox/thunderbird as well if it works.
Comment 5 Myckel Habets 2022-03-24 09:16:39 UTC
(In reply to Joonas Niilola from comment #4)
> (In reply to Myckel Habets from comment #3)
> > Created attachment 767641 [details, diff] [details, diff] [details, diff]
> > Updated conditional patch.
> 
> Oo this would've been a much cleaner solution for firefox/thunderbird as
> well if it works.

Feel free to adjust and use it. This patch helps with Gentoo having a stable and unstable version. I already send it to Seamonkey upstream and they accepted it in their patch queue with the remark that it will be removed when they backport the FF patch:

https://hg.mozilla.org/mozilla-central/rev/7c43b7cf95c4

This mostly contains changes involving the fact that they bundle the dav1d library, and not so much the the changed API.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-24 16:30:09 UTC
Could you make a PR with your patch?
Comment 7 Myckel Habets 2022-03-25 09:48:20 UTC
(In reply to Sam James from comment #6)
> Could you make a PR with your patch?

Sure, working on it.
Comment 8 Larry the Git Cow gentoo-dev 2022-03-26 13:54:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6f6ba1d2749d8a62db6b1f8fc0c4f50a5a07129

commit f6f6ba1d2749d8a62db6b1f8fc0c4f50a5a07129
Author:     Myckel Habets <gentoo-bugs@habets-dobben.nl>
AuthorDate: 2022-03-25 14:00:08 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-03-26 13:26:27 +0000

    www-client/seamonkey: bump version to 2.53.11-r1
    
    * Add patch to support media-libs/dav1d-1.0.0.
    
    Closes: https://bugs.gentoo.org/835828
    Signed-off-by: Myckel Habets <gentoo-bugs@habets-dobben.nl>
    Closes: https://github.com/gentoo/gentoo/pull/24744
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/seamonkey/Manifest                    |   1 +
 www-client/seamonkey/seamonkey-2.53.11-r1.ebuild | 553 +++++++++++++++++++++++
 2 files changed, 554 insertions(+)