Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 83472 - emacs toolkit scrollbars should be a USE flag
Summary: emacs toolkit scrollbars should be a USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-27 09:14 UTC by James Cloos
Modified: 2018-10-13 15:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
add toolkit-scroll-bars use flag to emacs-cvs 22.0.50 (22.0.50.diff,804 bytes, patch)
2005-06-09 22:21 UTC, James Cloos
Details | Diff
add toolkit-scroll-bars use flag to emacs-cvs 23.0.0 (23.0.0.diff,802 bytes, patch)
2005-06-09 22:22 UTC, James Cloos
Details | Diff
document first two patches in use.desc.local (uld.diff,622 bytes, patch)
2005-06-09 22:23 UTC, James Cloos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Cloos 2005-02-27 09:14:40 UTC
For emacs-22.0.50_pre... and all current emacs-cvs, the --with-toolkit-scroll-bars configure option is given unconditionally.

It should be another USE flag (perhaps toolkit-scrollbars) given that the toolkit menus et al (especially for gtk2) are significantly better but the non-toolkit scrollbars have better functionality....

In any case, the combination of:

   --with-x-toolkit=gtk --without-toolkit-scroll-bars

is common and should be supported by the ebuilds.
Comment 1 James Cloos 2005-06-09 22:21:43 UTC
Created attachment 60965 [details, diff]
add toolkit-scroll-bars use flag to emacs-cvs 22.0.50
Comment 2 James Cloos 2005-06-09 22:22:55 UTC
Created attachment 60966 [details, diff]
add toolkit-scroll-bars use flag to emacs-cvs 23.0.0
Comment 3 James Cloos 2005-06-09 22:23:36 UTC
Created attachment 60967 [details, diff]
document first two patches in use.desc.local
Comment 4 James Cloos 2005-06-09 22:28:11 UTC
I just added patches for emacs-cvs 22.0.50 and 23.0.0 that implement the
suggestion.  Also a patch to use.desc.local documenting it.

With this you need toolkit-scroll-bars in USE to get the toolkit's scrollbars.

Having -toolkit-scroll-bars results in emacs' own bars (which work like athena
bars and are therefore useful, unlike the br0rked gtk bars).

I used use_with to do this.  Another alternative is a -ve USE flag, such
that --with-toolkit-scroll-bars is the default and --without-toolkit-scroll-bars
is only used iff the USE flag is specified.  I'll redo the patches if that
is more likely to be applied.
Comment 5 Matthew Kennedy (RETIRED) gentoo-dev 2006-08-22 20:57:57 UTC
Thanks.  This is a great idea. I've added it to both emacs-cvs ebuilds and placed toolkit-scroll-bars in use.local.desc