Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 834082 - app-editors/vscodium: crash while starting with gui-libs/wlroots-0.15.0-r2
Summary: app-editors/vscodium: crash while starting with gui-libs/wlroots-0.15.0-r2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Adel KARA SLIMANE
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-02-26 12:08 UTC by David Sardari
Modified: 2022-05-08 18:35 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Sardari 2022-02-26 12:08:32 UTC
With gui-libs/wlroots-0.15.0-r2 installed, app-editors/vscodium is not able to start anymore.

Reproducible: Always

Steps to Reproduce:
1. Install gui-libs/wlroots-0.15.0-r2
2. Execute "/usr/bin/vscodium --enable-features=UseOzonePlatform --ozone-platform=wayland --verbose"
Actual Results:  
app-editors/vscodium fails to start with following output:

Warning: 'enable-features' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'ozone-platform' is not in the list of known options, but still passed to Electron/Chromium.
[12169:0226/122344.994958:WARNING:wayland_drm.cc(68)] Failed to get drm magic
interface 'wl_output' has no event 4
tcmalloc: large alloc 1073741824 bytes == 0x3f0976bef000 @  0x55837170d865 0x7f80db0ad166


Expected Results:  
app-editors/vscodium should start.

The bug has been reported upstream:
https://github.com/microsoft/vscode/issues/141964
Comment 1 David Sardari 2022-02-26 12:10:28 UTC
After downgrading, app-editors/vscodium starts as expected:

emerge -1 =gui-libs/wlroots-0.14.0-r2 =gui-wm/sway-1.6.1-r1
Comment 2 Adel KARA SLIMANE 2022-03-09 10:11:32 UTC
This looks like an issue with upstream Sway, have you tested with live ebuild sway or with a newer vscode version ?
Comment 3 David Sardari 2022-03-09 15:56:17 UTC
electron v13.6.9 has been patched:
https://github.com/electron/electron/releases/tag/v13.6.9

But, Visual Studio Code tries to fix this by upgrading to electron 17:
https://github.com/microsoft/vscode/issues/141964#issuecomment-1059971533

ArchLinux fixes this their own way:
https://github.com/microsoft/vscode/issues/141964#issuecomment-1059994413
Comment 4 Adel KARA SLIMANE 2022-03-09 16:00:20 UTC
Thank you for the additional information. Since the ebuild ships the binary version of the package, all we can do is wait, or do you have a suggestion ?
Comment 5 David Sardari 2022-03-09 16:04:50 UTC
Nothing comes to mind. app-editors/vscodium ebuilds could be updated to require the installation of <gui-libs/wlroots-0.15.0-r1.
Comment 6 David Sardari 2022-03-09 16:08:57 UTC
I meant to say:

... require the installation of gui-libs/wlroots:0/14.
Comment 7 Adel KARA SLIMANE 2022-03-09 16:13:44 UTC
Some don't use gui-libs/wlroots at all (like me), so I think it's better to just make a blocker:

RDEPEND="!>=gui-libs/wlroots-0.15"
Comment 8 David Sardari 2022-03-09 16:24:35 UTC
Even better :)
Comment 9 Larry the Git Cow gentoo-dev 2022-03-09 18:26:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=263d23c75207a9ea5cbcfec304cba08c74754173

commit 263d23c75207a9ea5cbcfec304cba08c74754173
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2022-03-09 16:27:47 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-03-09 18:26:02 +0000

    app-editors/{vscode,vscodium}: crashes with >=gui-libs/wlroots-0.15
    
    Bug: https://bugs.gentoo.org/834082
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Closes: https://github.com/gentoo/gentoo/pull/24459
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 app-editors/vscode/vscode-1.65.1.ebuild     | 1 +
 app-editors/vscodium/vscodium-1.65.1.ebuild | 1 +
 2 files changed, 2 insertions(+)
Comment 10 Niko Böckerman 2022-03-10 07:45:31 UTC
Blocking installation together with wlroots-0.15 is not the best solution. VSCodium can be launched as native wayland application and also as xwayland application. And default is xwayland as native wayland requires the extra "--enable-features=UseOzonePlatform --ozone-platform=wayland" flags.

And VSCodium crashes with wlroots only when launched as native wayland application. I have had VSCodium installed together with wlroots-0.15-r2 ever since wlroots-0.15 was stabilized several weeks ago. I did have to switch to using xwayland window, but I can still use it even with wlroots-0.15.

Therefore VSCodium shouldn't be marked as incompatible with wlroots-0.15 completely. I do agree that there should be some way to inform that vscodium wayland interface is not compatible with wlroots but preventing them from being installed together is too harsh measure. If a block is desired, then it should be through some "wayland" use flag or similar.
Alternatively a post install warning about the incompatibility could be enough.
Comment 11 Adel KARA SLIMANE 2022-03-10 08:16:01 UTC
I entirely forgot about xwayland and ended up thinking that it simply crashes with wlroot no matter the backend. I will revert the blocker. A post install message is more adequate indeed.
Comment 12 Larry the Git Cow gentoo-dev 2022-03-11 17:23:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e85a3a6b2466441a61a756c3cc8db2a2b1766b8b

commit e85a3a6b2466441a61a756c3cc8db2a2b1766b8b
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2022-03-11 16:08:42 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-03-11 17:23:27 +0000

    app-editors/vscode: version bump to 1.65.2
    
    Change wlroots blocker to an elog message
    
    Bug: https://bugs.gentoo.org/834082
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Closes: https://github.com/gentoo/gentoo/pull/24493
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 app-editors/vscode/Manifest                                      | 6 +++---
 .../vscode/{vscode-1.65.1.ebuild => vscode-1.65.2.ebuild}        | 9 ++++++++-
 2 files changed, 11 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04a58205cfbebd38f8427d6f6c4bf150a0c67191

commit 04a58205cfbebd38f8427d6f6c4bf150a0c67191
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2022-03-11 15:19:44 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-03-11 17:23:26 +0000

    app-editors/vscodium: version bump to 1.65.2
    
    Change wlroots blocker to an elog message
    
    Bug: https://bugs.gentoo.org/834082
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 app-editors/vscodium/Manifest                                    | 6 +++---
 .../vscodium/{vscodium-1.65.1.ebuild => vscodium-1.65.2.ebuild}  | 9 ++++++++-
 2 files changed, 11 insertions(+), 4 deletions(-)
Comment 13 Benedikt Reinartz 2022-03-21 13:42:58 UTC
This may not be the best approach for a distribution, but simply frankensteining electron 13.6.9 into vscode works fine at first glance :)

I downloaded the binary release from https://github.com/electron/electron/releases/download/v13.6.9/electron-v13.6.9-linux-x64.zip, unpacked it into the VSCode directory (/opt/vscode), renamed `electron` to `code` and fixed the permissions.
Comment 14 Adel KARA SLIMANE 2022-04-11 21:57:58 UTC
The PRs and issues David Sardari mentionned got merged. I cannot find fast enough in which release they will be available, or if it's already the case actually. Keep me updated so we can close this issue ! (I like to see that I have no issues assigned to me hehe)
Comment 15 Larry the Git Cow gentoo-dev 2022-05-08 18:35:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7cf93254fb80bbfb2c81446a0637422f5f0061ae

commit 7cf93254fb80bbfb2c81446a0637422f5f0061ae
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2022-05-07 19:57:37 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-05-08 18:35:34 +0000

    app-editors/vscodium: version bump to 1.67.0
    
    The wlroots issue related to Electron is fixed in this release
    Closes: https://bugs.gentoo.org/834082
    
    Drop arm version as upstream has issues bundling it for now
    See https://github.com/VSCodium/vscodium/issues/1072
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 app-editors/vscodium/Manifest               |   2 +
 app-editors/vscodium/vscodium-1.67.0.ebuild | 114 ++++++++++++++++++++++++++++
 2 files changed, 116 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bf4c072fc01ae88ba30163d7567135a6320081e

commit 7bf4c072fc01ae88ba30163d7567135a6320081e
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2022-05-07 19:43:45 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-05-08 18:35:34 +0000

    app-editors/vscode: version bump to 1.67.0
    
    The wlroots issue related to Electron is fixed in this release
    Closes: https://bugs.gentoo.org/834082
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 app-editors/vscode/Manifest             |   3 +
 app-editors/vscode/vscode-1.67.0.ebuild | 123 ++++++++++++++++++++++++++++++++
 2 files changed, 126 insertions(+)