Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833979 - media-sound/fluidsynth-2.3.3 calls cc directly
Summary: media-sound/fluidsynth-2.3.3 calls cc directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 921338
Blocks: tc-directly
  Show dependency tree
 
Reported: 2022-02-24 10:21 UTC by Agostino Sarubbo
Modified: 2024-01-26 08:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,52.56 KB, text/plain)
2022-02-24 10:21 UTC, Agostino Sarubbo
Details
1-CMakeError.log (1-CMakeError.log,2.38 KB, text/plain)
2022-02-24 10:21 UTC, Agostino Sarubbo
Details
1-CMakeOutput.log (1-CMakeOutput.log,48 bytes, text/plain)
2022-02-24 10:21 UTC, Agostino Sarubbo
Details
2-CMakeOutput.log (2-CMakeOutput.log,108.61 KB, text/plain)
2022-02-24 10:21 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-02-24 10:21:04 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/fluidsynth-2.2.5 calls cc directly.
Discovered on: amd64 (internal ref: ci)

NOTE:
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different CC implementation (like clang). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].
Comment 1 Agostino Sarubbo gentoo-dev 2022-02-24 10:21:06 UTC
Created attachment 765751 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-02-24 10:21:07 UTC
Created attachment 765752 [details]
1-CMakeError.log

1-CMakeError.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-02-24 10:21:08 UTC
Created attachment 765753 [details]
1-CMakeOutput.log

1-CMakeOutput.log
Comment 4 Agostino Sarubbo gentoo-dev 2022-02-24 10:21:09 UTC
Created attachment 765754 [details]
2-CMakeOutput.log

2-CMakeOutput.log
Comment 5 Agostino Sarubbo gentoo-dev 2022-02-24 10:21:11 UTC
Error(s) that match a know pattern:


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
  No CMAKE_C_COMPILER could be found.
--   Package 'libinstpatch-1.0', required by 'virtual:world', not found
Comment 6 Agostino Sarubbo gentoo-dev 2022-03-21 08:25:41 UTC
ci has reproduced this issue with version 2.2.6 - Updating summary.
Comment 7 Agostino Sarubbo gentoo-dev 2022-04-26 19:39:35 UTC
ci has reproduced this issue with version 2.2.7 - Updating summary.
Comment 8 Agostino Sarubbo gentoo-dev 2022-07-11 06:58:47 UTC
ci has reproduced this issue with version 2.2.8 - Updating summary.
Comment 9 Agostino Sarubbo gentoo-dev 2022-09-07 06:01:50 UTC
ci has reproduced this issue with version 2.2.9 - Updating summary.
Comment 10 Agostino Sarubbo gentoo-dev 2022-11-14 17:45:25 UTC
ci has reproduced this issue with version 2.3.0 - Updating summary.
Comment 11 Agostino Sarubbo gentoo-dev 2022-12-30 12:13:45 UTC
ci has reproduced this issue with version 2.3.1 - Updating summary.
Comment 12 Agostino Sarubbo gentoo-dev 2023-04-03 09:21:29 UTC
ci has reproduced this issue with version 2.3.2 - Updating summary.
Comment 13 Agostino Sarubbo gentoo-dev 2023-05-12 06:15:58 UTC
ci has reproduced this issue with version 2.3.2-r1 - Updating summary.
Comment 14 Agostino Sarubbo gentoo-dev 2023-05-29 09:59:20 UTC
ci has reproduced this issue with version 2.3.2-r2 - Updating summary.
Comment 15 Agostino Sarubbo gentoo-dev 2023-06-15 07:32:00 UTC
ci has reproduced this issue with version 2.3.3 - Updating summary.
Comment 16 Larry the Git Cow gentoo-dev 2024-01-23 09:57:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79268f1ce9c8e1e24a3f2d1ae539a696711e8587

commit 79268f1ce9c8e1e24a3f2d1ae539a696711e8587
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-01-23 09:57:29 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-01-23 09:57:29 +0000

    media-sound/fluidsynth: dropped obsolete 2.3.3
    
    Bug: https://bugs.gentoo.org/921338
    Closes: https://bugs.gentoo.org/833979
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/fluidsynth/Manifest                |   1 -
 media-sound/fluidsynth/fluidsynth-2.3.3.ebuild | 121 -------------------------
 2 files changed, 122 deletions(-)
Comment 17 Lucio Sauer 2024-01-23 14:35:40 UTC
This is not fixed yet. The issue seems to be the hacky cmake implementation to choose a CBUILD compiler for building the "make_tables" binary.

src/CMakeLists.txt adds instructions for the "make_tables" binary:
ExternalProject_Add(gentables
[...]
    CONFIGURE_COMMAND
        "${CMAKE_COMMAND}" -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE} -G "${CMAKE_GENERATOR}" -B "${GENTAB_BDIR}" "${GENTAB_SDIR}"
[...]
    INSTALL_COMMAND ${GENTAB_BDIR}/make_tables.exe "${FluidSynth_BINARY_DIR}/"
)

src/gentables/CMakeLists.txt unsets CC to force cmake to look for a C compiler, hopefully a CBUILD one.
Since the CMAKE_C_COMPILER macro is not passed in CONFIGURE_COMMAND, the CMakeDetermineCCompiler.cmake module tries and fails to determine a C compiler.

If I'm not mistaken, it first inspects the (unset) CC env var, then tries all of [cc,gcc,cl,bcc,xlc,icx,clang].
Comment 18 Miroslav Šulc gentoo-dev 2024-01-23 14:46:19 UTC
thanks. the bug was not updated to the latest version so i thought it's fixed.
Comment 19 Lucio Sauer 2024-01-24 16:45:44 UTC
Upstream bug report: https://github.com/FluidSynth/fluidsynth/issues/1301
Comment 20 Larry the Git Cow gentoo-dev 2024-01-26 08:01:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb429b5ab3758bb6169613749496c2070e3c4d8e

commit fb429b5ab3758bb6169613749496c2070e3c4d8e
Author:     Lucio Sauer <watermanpaint@posteo.net>
AuthorDate: 2024-01-25 09:04:34 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-01-26 07:57:13 +0000

    media-sound/fluidsynth: prevent faulty CMake C compiler detection
    
    Manually pass CMAKE_C_COMPILER to subprocess, which relies on
    insufficient CMake compiler auto-detection to detect a suitable CBUILD
    C compiler.
    
    Closes: https://bugs.gentoo.org/833979
    Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/34989
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/fluidsynth/fluidsynth-2.3.4-r1.ebuild | 149 ++++++++++++++++++++++
 1 file changed, 149 insertions(+)