Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 832703 - auto-CC for bugs modified via commit tags
Summary: auto-CC for bugs modified via commit tags
Status: CONFIRMED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-04 14:35 UTC by Michael Orlitzky
Modified: 2022-02-06 08:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2022-02-04 14:35:48 UTC
Follow-up to,

https://archives.gentoo.org/gentoo-dev/message/9e875b528eee3732e2c1ff34b791006d

It would be helpful if, when a git hook modifies a bug, it CCs the committer who triggered the edit.

There are several "open" maintainers, for example maintainer-needed and sci*, where it's acceptable to make drive-by commits as a non-maintainer. Often a bug assigned to those addresses will get closed by a commit hook, and someone will later comment on the fix -- as in, "thanks," or "it's still broken on x86." If the committer doesn't remember to CC himself on the bug, he'll miss that comment. Automating the process is less error-prone, and avoids sending everyone an extra email upon the box being checked.

The main technical detail to work out is how to avoid CCing the committer twice, if he's already CCed via an alias. For this it may suffice to loop through projects.xml, since only developers can be the committer (as opposed to the commit author). That isn't a bullet-proof solution, but getting an extra email every once in a while due to a corner case is also not a huge deal.
Comment 1 Joonas Niilola gentoo-dev 2022-02-06 07:54:22 UTC
> The main technical detail to work out is how to avoid CCing the committer twice, 
> if he's already CCed via an alias.

^ AFAIK ago has that worked out. CCing ago, any help?
Comment 2 Agostino Sarubbo gentoo-dev 2022-02-06 08:22:20 UTC
(In reply to Joonas Niilola from comment #1)
> > The main technical detail to work out is how to avoid CCing the committer twice, 
> > if he's already CCed via an alias.
> 
> ^ AFAIK ago has that worked out. CCing ago, any help?

Hi,

atm I'm just CC'ing when the assignee is different from the committer.

This helps in visibility expecially when people organizes mails from alias into a different directory.

To avoid double-cc (or double mail) I see two possibilities:

1) Have an API that should be called at runtime
2) Store the alias somewhere on the machine, but it may be out of sync at some time.